Bug 28320 - SharedWorkers need to forward exceptions to parent documents
Summary: SharedWorkers need to forward exceptions to parent documents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-14 14:51 PDT by Andrew Wilson
Modified: 2009-08-18 15:16 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (9.70 KB, patch)
2009-08-14 15:04 PDT, Andrew Wilson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-08-14 14:51:31 PDT
Currently, exceptions/parse errors in SharedWorker script are silently swallowed. We need to forward these exceptions to all parent documents so they can be logged/displayed to the user.
Comment 1 Andrew Wilson 2009-08-14 15:04:52 PDT
Created attachment 34874 [details]
proposed patch
Comment 2 David Levin 2009-08-18 12:12:06 PDT
Comment on attachment 34874 [details]
proposed patch

It looks good except for one thing: Consider creating a fast/workers/resources/TEMPLATE and then run WebKitTools/Scripts/make-script-test-wrappers to generate shared-worker-exception.html-disabled (You'll likely need to add some exceptions in that script as well.)


This may not be the right path so if it turns out to be a lot of work speak up.
Comment 3 Andrew Wilson 2009-08-18 13:45:18 PDT
Looks like a bunch of work for little/no gain.

make-script-test-wrappers doesn't keep <xxxx>.html-disabled files up-to-date, and doesn't currently support generating multiple HTML files from a single template (which we need to do to support both workers and shared-workers).
Comment 4 Eric Seidel (no email) 2009-08-18 14:12:19 PDT
Comment on attachment 34874 [details]
proposed patch

Rejecting patch 34874 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'rebase']"  exit_code: 1  cwd: None
Comment 5 Eric Seidel (no email) 2009-08-18 14:25:12 PDT
Comment on attachment 34874 [details]
proposed patch

Sorry, we hit https://bugs.webkit.org/show_bug.cgi?id=28436
Comment 6 Eric Seidel (no email) 2009-08-18 15:16:04 PDT
Comment on attachment 34874 [details]
proposed patch

Clearing flags on attachment: 34874

Committed r47460: <http://trac.webkit.org/changeset/47460>
Comment 7 Eric Seidel (no email) 2009-08-18 15:16:07 PDT
All reviewed patches have been landed.  Closing bug.