Bug 28320 – SharedWorkers need to forward exceptions to parent documents

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Andrew Wilson]

Currently, exceptions/parse errors in SharedWorker script are silently swallowed. We need to forward these exceptions to all parent documents so they can be logged/displayed to the user.

[Andrew Wilson]

Created attachment 34874 [details]
proposed patch

[David Levin]

Comment on attachment 34874 [details]
proposed patch

It looks good except for one thing: Consider creating a fast/workers/resources/TEMPLATE and then run WebKitTools/Scripts/make-script-test-wrappers to generate shared-worker-exception.html-disabled (You'll likely need to add some exceptions in that script as well.)


This may not be the right path so if it turns out to be a lot of work speak up.

[Andrew Wilson]

Looks like a bunch of work for little/no gain.

make-script-test-wrappers doesn't keep <xxxx>.html-disabled files up-to-date, and doesn't currently support generating multiple HTML files from a single template (which we need to do to support both workers and shared-workers).

[Eric Seidel (no email)]

Comment on attachment 34874 [details]
proposed patch

Rejecting patch 34874 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'rebase']"  exit_code: 1  cwd: None

[Eric Seidel (no email)]

Comment on attachment 34874 [details]
proposed patch

Sorry, we hit https://bugs.webkit.org/show_bug.cgi?id=28436

[Eric Seidel (no email)]

Comment on attachment 34874 [details]
proposed patch

Clearing flags on attachment: 34874

Committed r47460: <http://trac.webkit.org/changeset/47460>

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.