RESOLVED FIXED 283141
Make the pre-push template syntactically valid Python 
https://bugs.webkit.org/show_bug.cgi?id=283141
Summary Make the pre-push template syntactically valid Python
Sam Sneddon [:gsnedders]
Reported 2024-11-14 15:23:24 PST
This is the only one of the hook templates that is itself syntactically invalid Python: File "Tools/Scripts/hooks/pre-push", line 50 SECURITY_LEVELS = { {% for key, value in security_levels.items() %} ^ SyntaxError: invalid syntax We should make the relatively small changes to make it syntactically valid so we can use normal Python linting and tooling when working with it.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2024-11-14 15:30:01 PST
Pull request: https://github.com/WebKit/WebKit/pull/36668
Radar WebKit Bug Importer
Comment 2 2024-11-21 15:24:17 PST
<rdar://problem/140379280>
EWS
Comment 3 2024-12-03 11:36:46 PST
merge-queue failed to commit PR to repository. To retry, remove any blocking labels and re-apply merge-queue label
EWS
Comment 4 2024-12-03 15:18:49 PST
Committed 287311@main (6dae686bbeaf): <https://commits.webkit.org/287311@main> Reviewed commits have been landed. Closing PR #36668 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.