Bug 28311 - [Chromium] DOMWindowEvent custom getter failing on cross frame requests
Summary: [Chromium] DOMWindowEvent custom getter failing on cross frame requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-14 12:16 PDT by Nate Chapin
Modified: 2009-08-17 16:37 PDT (History)
2 users (show)

See Also:


Attachments
patch (1.74 KB, patch)
2009-08-14 12:25 PDT, Nate Chapin
dglazkov: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2009-08-14 12:16:10 PDT
r47130 only added proper cross-frame handling to the DOMWindowEvent setter.  Need to add it to the getter as well.

LayoutTests/fast/events/set-event-in-another-frame.html is currently failing when using V8 because of this.
Comment 1 Nate Chapin 2009-08-14 12:25:36 PDT
Created attachment 34866 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2009-08-14 12:27:22 PDT
Comment on attachment 34866 [details]
patch

r=me.
Comment 3 Eric Seidel (no email) 2009-08-17 16:26:06 PDT
Comment on attachment 34866 [details]
patch

Nate's a committer, so marking cq-.  He can mark it cq+ himself if he'd like the bot to land it for him.
Comment 4 Nate Chapin 2009-08-17 16:32:31 PDT
Once again, I've committed a patch and failed to update the bug :-(

Landed at 47293.
Comment 5 Eric Seidel (no email) 2009-08-17 16:37:42 PDT
of course bugzilla-tool land-diff is available to do the landing and bug updating for you if you like. ;)