Bug 28305 - When Geolocation permissions are denied, watchers are not stopped
Summary: When Geolocation permissions are denied, watchers are not stopped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks: 29040
  Show dependency treegraph
 
Reported: 2009-08-14 07:57 PDT by Steve Block
Modified: 2009-09-09 09:04 PDT (History)
5 users (show)

See Also:


Attachments
Patch 1 for bug 28305 (11.96 KB, patch)
2009-09-09 02:38 PDT, Steve Block
darin: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-08-14 07:57:50 PDT
Currently, when Geolocation permissions are denied, only one-shots are stopped.

Since permissions can not be revoked within the lifetime of the page, all requests (both one-shots and watchers) will never obtain a position fix once permissions have been denied. We should therefore stop all requests when permissions are denied.
Comment 1 Steve Block 2009-09-08 10:49:25 PDT
The refactoring required for Bug 29040 requires this bug to be fixed first.
Comment 2 Steve Block 2009-09-09 02:38:41 PDT
Created attachment 39256 [details]
Patch 1 for bug 28305

Fixes the bug and adds tests.
Comment 3 Eric Seidel (no email) 2009-09-09 08:24:36 PDT
Comment on attachment 39256 [details]
Patch 1 for bug 28305

Rejecting patch 39256 from commit-queue.

benm@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment 4 Ben Murdoch 2009-09-09 08:46:23 PDT
(In reply to comment #3)
> (From update of attachment 39256 [details])
> Rejecting patch 39256 from commit-queue.
> 
> benm@google.com does not have committer permissions according to
> http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

Hmm, not sure what happened there. I'm on line 50 of that script? Will land manually.
Comment 5 Ben Murdoch 2009-09-09 09:04:17 PDT
Landed as r48209.