RESOLVED FIXED 28298
[ES5] Arguments object should inherit from Array 
https://bugs.webkit.org/show_bug.cgi?id=28298
Summary [ES5] Arguments object should inherit from Array
Oliver Hunt
Reported 2009-08-14 03:40:47 PDT
ES5 says that the Arguments should inherit from array (Section 10.6). Specifically that construction of the Arguments object is as follows (assuming Object and Array are the standard builtin Object and Array objects, and that their prototypes are unchanged): obj = new Object with the class Arguments obj.__proto__ = Array.prototype obj.constructor = Object obj.toString = Object.prototype.toString obj.toLocalString = Object.prototype.toLocaleString
Attachments
Patch v1 (59.39 KB, patch)
2009-08-14 04:35 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch v1 (19.28 KB, patch)
2009-08-14 13:07 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2009-08-14 04:35:56 PDT
Created attachment 34826 [details] Patch v1
Gavin Barraclough
Comment 2 2009-08-14 13:01:44 PDT
You seem to be checking in another mozilla test failing? If so, is this intentional, could you not just fix the test?
Oliver Hunt
Comment 3 2009-08-14 13:02:27 PDT
I suppose i could do that...
Oliver Hunt
Comment 4 2009-08-14 13:07:58 PDT
Created attachment 34869 [details] Patch v1
Oliver Hunt
Comment 5 2009-08-14 13:08:19 PDT
Gavin i has fixed it
Oliver Hunt
Comment 6 2009-08-14 13:19:36 PDT
Committed r47292
Note You need to log in before you can comment on or make changes to this bug.