Bug 28297 - WebInspector: Wrap console objects late (in the frontend) so that injected script was already in place.
Summary: WebInspector: Wrap console objects late (in the frontend) so that injected sc...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2009-08-14 02:32 PDT by Pavel Feldman
Modified: 2009-08-14 04:39 PDT (History)
1 user (show)

See Also:

patch (9.70 KB, patch)
2009-08-14 03:11 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-08-14 02:32:52 PDT
Otherwise, console.log being executed before frontend has started causes operation on uninitialized ScriptObject.
Comment 1 Pavel Feldman 2009-08-14 03:11:09 PDT
Created attachment 34823 [details]

This patch moves stack processing back to the ConsoleMessage and introduces dependency from InspectorFrontend to the InspectorController for object wrapping.

It actually reverts ConsoleMessage.* to where they were before the DOMAgent-related change.
Comment 2 Pavel Feldman 2009-08-14 04:39:56 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/ConsoleMessage.cpp
	M	WebCore/inspector/ConsoleMessage.h
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/InspectorFrontend.h
Committed r47277