Bug 28290 – Inspector: Resources Search Should Search Only Filtered Resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Joseph Pecoraro]

Created attachment 34802 [details]
IMAGE: "Filtered Out" Resource Appears During a Search

Example:

1. Choose the "Images" Filter
2. Search for "color"

Its likely that CSS Stylesheets will start to appear in the sidebar, even though they should have been filtered.

[Joseph Pecoraro]

I didn't set that patch as r? because I had some other things that I was wondering about:

Another developer emailed me with some feedback about the "webkit cookie api".  He listed a number of good points.  I think I should work on cleaning up and drafting a good cookie api now, rather then adding it piecewise like I have been doing.  Some of the suggestions that came out of our email exchange where:

- Change the name of "getRawCookies" to something better like "cookiesList", and apparently returning a bool is not consistent with other sections.  This seems more appropriate:

void cookiesList(const Document* document, const KURL& url, Vector<Cookie>& cookiesList, bool& implemented = false);

- Change the name of "deleteCookie" to "deleteCookieByName" which is more correct.  I think this is also a good idea.

- It would be nice to prepare for adding support for Creating/Modifying cookies.  This behavior must already be possible via CookieJar's already existing setCookies(.., .., String).  I think it would be appropriate to provide an addCookie convenience function and possibly updateCookieByName.  Or should these be avoided in favor of specific calls to setCookies?

- He raised a good point as well => "On this topic what is the goal of the Cookie.h class?  The file didn't contain any comments.  Is it just for the inspector currently?  Any long term plans?  It would be nice to have a unified string -> cookie parser for all webkit as it is such as messy job and every port does it a tiny bit differently."

Any ideas if there could be plans to "unify string cookie parsing" rather then the current platform specific  mess, or are things too coupled to the network stacks?

[Joseph Pecoraro]

Totally left that comment on the wrong bug, sorry Rik.

[Alexander Pavlov (apavlov)]

Created attachment 61932 [details]
[PATCH] Suggested solution

[Alexander Pavlov (apavlov)]

Created attachment 61933 [details]
[PATCH] Code slightly simplified

[Pavel Feldman]

Comment on attachment 61933 [details]
[PATCH] Code slightly simplified

~

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/inspector/front-end/AbstractTimelinePanel.js
        M       WebCore/inspector/front-end/ResourcesPanel.js
        M       WebCore/inspector/front-end/inspector.js
Committed r63741