RESOLVED FIXED 282897
[RISCV] Add OFFLINE_ASM_ALIGN_TRAP implementation for RISCV 
https://bugs.webkit.org/show_bug.cgi?id=282897
Summary [RISCV] Add OFFLINE_ASM_ALIGN_TRAP implementation for RISCV
MingZhu Yan
Reported 2024-11-10 08:21:01 PST
Meet this error during compiling on my riscv64gc board ```txt In file included from /home/debian/repo/WebKit/Source/JavaScriptCore/1lint/LowLevellnterpreter.cpp:647: /home/debian/repo/WebKit/webkitbuild/JavaScriptCore/DerivedSources/LLIntAssembly.h:116252:1: error: expected ')' OFFLINE_ASM_ALIGNED_GLOBAL_LABEL(ipint_unreachable_validate, 256) A /home/debian/repo/WebKit/Source/JavaScriptCore/1lint/LowLevelInterpreter.cpp:611:78: note: expanded from macro 'OFFLINE_ASM_ALIGNED_GLOBAL_LABEL' OFFLINE_ASM_GLOBAL_LABEL_IMPL(label, OFFLINE_ASM_NO_ALT_ENTRY_DIRECTIVE, DFFLINE_ASM_ALIGN_TRAP(align), HIDE_SYMBOL) ^ /home/debian/repo/WebKit/webkitbuild/JavaScriptCore/DerivedSources/LLINntAssembly.h:3:1: note: to match this '(' ``` I'll send a pr later
Attachments
Add attachment proposed patch, testcase, etc.
MingZhu Yan
Comment 1 2024-11-10 08:37:50 PST
Pull request: https://github.com/WebKit/WebKit/pull/36458
EWS
Comment 2 2024-11-10 09:48:05 PST
Committed 286407@main (0752f78b9bc4): <https://commits.webkit.org/286407@main> Reviewed commits have been landed. Closing PR #36458 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-11-10 09:49:12 PST
<rdar://problem/139602487>
Note You need to log in before you can comment on or make changes to this bug.