Bug 282890 – [ANGLE] Fix leaks in NewMetalLibraryFromMetallib() on every call

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[David Kilzer (:ddkilzer)]

NewMetalLibraryFromMetallib() leaks id<MTLLibrary> on every call.

Regressed with this change:

-        return context->getMetalDevice().newLibraryWithData(mtl_data, &nsError);
+        return [metalDevice newLibraryWithData:mtl_data error:&nsError];

Because the C++ function was returning AutoObjCPtr<id<MTLLibrary>> but the Objective-C method returns a +1 retained id<MTLLibrary>.

For this commit:

    Update ANGLE to 2024-07-31 (3e83d1887e2bad0d5dac01b37fa94b88188ecd4f)
    <https://bugs.webkit.org/show_bug.cgi?id=277410>
    <rdar://problem/132885219>
    <https://commits.webkit.org/281691@main>

[Radar WebKit Bug Importer]

<rdar://problem/139586222>

[David Kilzer (:ddkilzer)]

Pull request: https://github.com/WebKit/WebKit/pull/36455

[EWS]

Committed 286425@main (8826887be8c6): <https://commits.webkit.org/286425@main>

Reviewed commits have been landed. Closing PR #36455 and removing active labels.

[Kenneth Russell]

FYI https://issues.angleproject.org/issues/378464308 has been filed about upstreaming this fix to ANGLE.

[EWS]

Committed 283286.473@safari-7620-branch (c5e92067cac8): <https://commits.webkit.org/283286.473@safari-7620-branch>

Reviewed commits have been landed. Closing PR #2272 and removing active labels.