RESOLVED FIXED 28287
Too much use of void* in Grammar.y 
https://bugs.webkit.org/show_bug.cgi?id=28287
Summary Too much use of void* in Grammar.y
Darin Adler
Reported 2009-08-13 16:44:54 PDT
Need to fix up the type casting and a couple other things in the Grammar.y file.
Attachments
patch (85.33 KB, patch)
2009-08-13 17:09 PDT, Darin Adler 		staikos: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2009-08-13 17:09:05 PDT
Created attachment 34798 [details] patch
George Staikos
Comment 2 2009-08-13 17:24:12 PDT
Generally nice patch, though it does a lot more than just void* cleanup. It's safe to assume you don't have a clean way to split the different changes up?
Darin Adler
Comment 3 2009-08-13 17:36:41 PDT
(In reply to comment #2) > Generally nice patch, though it does a lot more than just void* cleanup. It's > safe to assume you don't have a clean way to split the different changes up? It could easily be split into pieces. Since all these changes are mechanical I thought someone might review them in this form.
Darin Adler
Comment 4 2009-08-13 17:39:53 PDT
Note that this patch itself is basically a broken out piece of <https://bugs.webkit.org/attachment.cgi?id=30279&action=prettypatch>.
George Staikos
Comment 5 2009-08-13 17:40:12 PDT
Comment on attachment 34798 [details] patch I've been doing so. I'm happy to r+ this as-is but I think it would be nicer to commit it in a few pieces.
Note You need to log in before you can comment on or make changes to this bug.