Bug 28287 - Too much use of void* in Grammar.y
Summary: Too much use of void* in Grammar.y
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-13 16:44 PDT by Darin Adler
Modified: 2009-08-13 17:58 PDT (History)
1 user (show)

See Also:


Attachments
patch (85.33 KB, patch)
2009-08-13 17:09 PDT, Darin Adler
staikos: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2009-08-13 16:44:54 PDT
Need to fix up the type casting and a couple other things in the Grammar.y file.
Comment 1 Darin Adler 2009-08-13 17:09:05 PDT
Created attachment 34798 [details]
patch
Comment 2 George Staikos 2009-08-13 17:24:12 PDT
Generally nice patch, though it does a lot more than just void* cleanup.  It's safe to assume you don't have a clean way to split the different changes up?
Comment 3 Darin Adler 2009-08-13 17:36:41 PDT
(In reply to comment #2)
> Generally nice patch, though it does a lot more than just void* cleanup.  It's
> safe to assume you don't have a clean way to split the different changes up?

It could easily be split into pieces. Since all these changes are mechanical I thought someone might review them in this form.
Comment 4 Darin Adler 2009-08-13 17:39:53 PDT
Note that this patch itself is basically a broken out piece of <https://bugs.webkit.org/attachment.cgi?id=30279&action=prettypatch>.
Comment 5 George Staikos 2009-08-13 17:40:12 PDT
Comment on attachment 34798 [details]
patch

I've been doing so.  I'm happy to r+ this as-is but I think it would be nicer to commit it in a few pieces.