Bug 28286 - bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
: bugzilla-tool/commit-queue needs to upload failure logs when patches are reje...
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-08-13 16:16 PST by
Modified: 2009-12-15 02:39 PST (History)


Attachments
Patch (3.16 KB, patch)
2009-12-15 02:26 PST, Eric Seidel
abarth: review+
eric: commit‑queue+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-08-13 16:16:30 PST
bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected

the commit-queue script I'm running keeps a log locally.  But bugzilla-tool/commit-queue is not smart enough to know how to upload that log to the bug when a failure occurs.

it will also need to split out just the relevant sections of the log.

Adding these logs to bugs would clear up a lot of confusion around the commit-queue.
------- Comment #1 From 2009-12-15 02:21:52 PST -------
For now we're going to upload the failure logs to app engine instead of the bug.  We could change things to upload them to the bug as well at a later date.
------- Comment #2 From 2009-12-15 02:26:01 PST -------
Created an attachment (id=44854) [details]
Patch
------- Comment #3 From 2009-12-15 02:30:14 PST -------
style-queue ran check-webkit-style on attachment 44854 [details] without any errors.
------- Comment #4 From 2009-12-15 02:30:55 PST -------
(From update of attachment 44854 [details])
Nice!  One step closer to real ultimate power.
------- Comment #5 From 2009-12-15 02:39:27 PST -------
Committed r52147: <http://trac.webkit.org/changeset/52147>