RESOLVED FIXED 282841
[css-masonry] Update Intrinsic Sizing Rows 003 Auto Expected / Ref Test Case 
https://bugs.webkit.org/show_bug.cgi?id=282841
Summary [css-masonry] Update Intrinsic Sizing Rows 003 Auto Expected / Ref Test Case
Brandon
Reported 2024-11-08 10:17:50 PST
The 27.02px width when calculating “3 3” adds challenges for these tests. The Ahem font is more straightforward for the test cases as it results in a width of 27px. * Grid 2 We cannot create an invisible item, because it would add a gap at the end of the grid. Modify 5 5 to be a height of 2ch to match the original test case. * Grid 4 The item 3 3 should not span 2 columns, because it creates an empty column that adds a gap to the end of the grid. * Grid 5 Same problem as grid 4. * Grid 6 Same problem as grid 4. Removed the extra 5 not found in the original test case. * Grid 7-9 Creating an empty column 2 causes problems because there is now an extra grid gap that causes an extra 2px gap between the columns.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-11-08 10:18:05 PST
<rdar://problem/139521637>
Brandon
Comment 2 2024-11-08 10:18:59 PST
Pull request: https://github.com/WebKit/WebKit/pull/36403
EWS
Comment 3 2024-11-11 14:41:42 PST
Committed 286454@main (6522954a8084): <https://commits.webkit.org/286454@main> Reviewed commits have been landed. Closing PR #36403 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.