RESOLVED FIXED 282799
[CMake] Only override find_package on Apple targets 
https://bugs.webkit.org/show_bug.cgi?id=282799
Summary [CMake] Only override find_package on Apple targets
Don Olmstead
Reported 2024-11-07 18:41:56 PST
...
Attachments
Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2024-11-07 19:05:01 PST
Pull request: https://github.com/WebKit/WebKit/pull/36365
Max Schmitt
Comment 2 2024-11-08 04:53:31 PST
Note: This fixes a vcpkg/cmake recursion issue when export CMAKE_TOOLCHAIN_FILE=/c/vcpkg/scripts/buildsystems/vcpkg.cmake got used: CMake Error at C:/vcpkg/scripts/buildsystems/vcpkg.cmake:774 (if): Maximum recursion depth of 1000 exceeded Call Stack (most recent call first): .... C:/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package) C:/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package) C:/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package) Source/cmake/WebKitFindPackage.cmake:36 (_find_package) Source/cmake/OptionsWin.cmake:59 (find_package) Source/cmake/WebKitCommon.cmake:237 (include) CMakeLists.txt:16 (include)
EWS
Comment 3 2024-11-08 07:40:06 PST
Committed 286337@main (795afa80a9cc): <https://commits.webkit.org/286337@main> Reviewed commits have been landed. Closing PR #36365 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.