RESOLVED FIXED Bug 28278
Return type of getRGBColorValue needs to be changed to PassRefPtr to avoid memory leak 
https://bugs.webkit.org/show_bug.cgi?id=28278
Summary Return type of getRGBColorValue needs to be changed to PassRefPtr to avoid me...
Ryosuke Niwa
Reported 2009-08-13 14:00:38 PDT
CSSPrimitiveValue:: getRGBColorValue creates a new RGBColor object and releases the RefPtr. But the return type is a C pointer so that callers of this function may not necessarily assign it to PassRef, which results in a memory leak.
Attachments
Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2009-08-13 14:02:21 PDT
Relevant Changeset: http://trac.webkit.org/changeset/29189 http://trac.webkit.org/changeset/46211
Mark Rowe (bdash)
Comment 2 2009-08-13 15:31:10 PDT
I fixed this with <http://trac.webkit.org/changeset/47230> and <http://trac.webkit.org/changeset/47232> earlier.
Ryosuke Niwa
Comment 3 2009-08-13 15:46:04 PDT
(In reply to comment #2) > I fixed this with <http://trac.webkit.org/changeset/47230> and > <http://trac.webkit.org/changeset/47232> earlier. Ah! should have been watching the waterfall. Thanks! This is a great improvement.
Note You need to log in before you can comment on or make changes to this bug.