Bug 282764 – https://state-of-html-2024.onrender.com/en-US/opinions/ - does not show `x` center of circle

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ahmad Saleem]

Hi Team,

Go to preliminary results of `state of HTML` survey:

URL - https://state-of-html-2024.onrender.com/en-US/

*** Steps to Reproduce ***

(1) Go to `Opinions` from left pane
(2) Click on `Add Filters`
(3) Click on `Add Series`

*** Expected Results ***

Notice `X` (close) button of `Add Series`

*** Actual Result ***

It should be center as button

___

Just raising so we can fix it.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/139444773>

[Sammy Gill]

Created attachment 473172 [details]
Testcase

Attaching reduced test case

[zalan]

Not sure if this test reduction is correct. I assume PASS is when green box is centered and while it is indeed off-centered in some old builds, recent spades (e.g. 286297@main) shows it centered while https://state-of-html-2024.onrender.com/en-US/ still fails.

[zalan]

(In reply to zalan from comment #3)
> Not sure if this test reduction is correct. I assume PASS is when green box
> is centered and while it is indeed off-centered in some old builds, recent
> spades (e.g. 286297@main) shows it centered while
> https://state-of-html-2024.onrender.com/en-US/ still fails.
unless I have a wrong assumption on PASS here (annotation would certainly help)

[Sammy Gill]

Created attachment 473173 [details]
Testcase

I believe this is still broken on ToT testing with a spade. I reworked the test case a bit to state what the PASS criteria is (vertically and horizontally centered) and the grid should be larger in this version.

[zalan]

(In reply to Sammy Gill from comment #5)
> Created attachment 473173 [details]
> Testcase
> 
> I believe this is still broken on ToT testing with a spade. I reworked the
> test case a bit to state what the PASS criteria is (vertically and
> horizontally centered) and the grid should be larger in this version.
it is also a slightly different test case :)

[zalan]

with pinch zooming and constant reloading the first test case fails too. The second test case is much better.

[Sammy Gill]

Pull request: https://github.com/WebKit/WebKit/pull/36414

[Sammy Gill]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/49078

[EWS]

Committed 286367@main (30864f828c21): <https://commits.webkit.org/286367@main>

Reviewed commits have been landed. Closing PR #36414 and removing active labels.

[EWS]

Committed 283286.480@safari-7620-branch (ededfc5bd7a0): <https://commits.webkit.org/283286.480@safari-7620-branch>

Reviewed commits have been landed. Closing PR #2271 and removing active labels.