Bug 282758 – [Navigation] 286180@main introduced a assertion failure

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Claudio Saavedra]

I believe this was introduced here https://commits.webkit.org/286180@main

At least the following tests are asserting in the same place:

imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-same-document-in-iframe.html
imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-same-document.html
imported/w3c/web-platform-tests/navigation-api/navigation-methods/forward-to-pruned-entry.html

STDERR: warning: Section `.reg-xstate/3275' in core file too small.
STDERR: ASSERTION FAILED: container.vm().currentThreadIsHoldingAPILock()
STDERR: /app/webkit/Source/JavaScriptCore/heap/WeakSetInlines.h(36) : static JSC::WeakImpl* JSC::WeakSet::allocate(JSC::JSValue, JSC::WeakHandleOwner*, void*)
STDERR: 1   0x7fdb2d4cd9ff JSC::WeakSet::allocate(JSC::JSValue, JSC::WeakHandleOwner*, void*)
STDERR: 2   0x7fdb2eef4bae JSC::Weak<JSC::JSCell>::Weak(JSC::JSCell*, JSC::WeakHandleOwner*, void*)
STDERR: 3   0x7fdb31f47ea3 WebCore::JSValueInWrappedObject::setWeakly(JSC::JSValue)
STDERR: 4   0x7fdb31f47e15 WebCore::JSValueInWrappedObject::JSValueInWrappedObject(JSC::JSValue)
STDERR: 5   0x7fdb344be36a WebCore::NavigateEvent::NavigateEvent(WTF::AtomString const&, WebCore::NavigateEvent::Init const&, WebCore::EventIsTrusted, WebCore::AbortController*)
STDERR: 6   0x7fdb344be45a WebCore::NavigateEvent::create(WTF::AtomString const&, WebCore::NavigateEvent::Init const&, WebCore::AbortController*)
STDERR: 7   0x7fdb344c65ff WebCore::Navigation::innerDispatchNavigateEvent(WebCore::NavigationNavigationType, WTF::Ref<WebCore::NavigationDestination, WTF::RawPtrTraits<WebCore::NavigationDestination>, WTF::DefaultRefDerefTraits<WebCore::NavigationDestination> >&&, WTF::String const&, WebCore::FormState*, WebCore::SerializedScriptValue*)
STDERR: 8   0x7fdb344c7164 WebCore::Navigation::dispatchTraversalNavigateEvent(WebCore::HistoryItem&)
STDERR: 9   0x7fdb34231b36 WebCore::FrameLoader::loadItem(WebCore::HistoryItem&, WebCore::HistoryItem*, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
STDERR: 10  0x7fdb34250d0c WebCore::HistoryController::recursiveGoToItem(WebCore::HistoryItem&, WebCore::HistoryItem*, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
STDERR: 11  0x7fdb34250ec7 WebCore::HistoryController::recursiveGoToItem(WebCore::HistoryItem&, WebCore::HistoryItem*, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
STDERR: 12  0x7fdb3424da57 WebCore::HistoryController::goToItem(WebCore::HistoryItem&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
STDERR: 13  0x7fdb34506ae0 WebCore::Page::goToItem(WebCore::LocalFrame&, WebCore::HistoryItem&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
STDERR: 14  0x7fdb3426ee3a WebCore::ScheduledHistoryNavigationByKey::fire(WebCore::Frame&)
STDERR: 15  0x7fdb34271512 WebCore::NavigationScheduler::timerFired()
STDERR: 16  0x7fdb342743ea WebCore::Timer::Timer<WebCore::NavigationScheduler, WebCore::NavigationScheduler>(WebCore::NavigationScheduler&, void (WebCore::NavigationScheduler::*)())::{lambda()#1}::operator()() const
STDERR: 17  0x7fdb3427eeb4 WTF::Detail::CallableWrapper<WebCore::Timer::Timer<WebCore::NavigationScheduler, WebCore::NavigationScheduler>(WebCore::NavigationScheduler&, void (WebCore::NavigationScheduler::*)())::{lambda()#1}, void>::call()
STDERR: 18  0x7fdb2ba697ed WTF::Function<void ()>::operator()() const
STDERR: 19  0x7fdb2bf2ace4 WebCore::Timer::fired()
STDERR: 20  0x7fdb3479eeb8 WebCore::ThreadTimers::sharedTimerFiredInternal()
STDERR: 21  0x7fdb3479e743 operator()
STDERR: 22  0x7fdb347ad85e call
STDERR: 23  0x7fdb2ba697ed WTF::Function<void ()>::operator()() const
STDERR: 24  0x7fdb3474f460 WebCore::MainThreadSharedTimer::fired()
STDERR: 25  0x7fdb34757840 void std::__invoke_impl<void, void (WebCore::MainThreadSharedTimer::*&)(), WebCore::MainThreadSharedTimer*&>(std::__invoke_memfun_deref, void (WebCore::MainThreadSharedTimer::*&)(), WebCore::MainThreadSharedTimer*&)
STDERR: 26  0x7fdb347577b9 std::__invoke_result<void (WebCore::MainThreadSharedTimer::*&)(), WebCore::MainThreadSharedTimer*&>::type std::__invoke<void (WebCore::MainThreadSharedTimer::*&)(), WebCore::MainThreadSharedTimer*&>(void (WebCore::MainThreadSharedTimer::*&)(), WebCore::MainThreadSharedTimer*&)
STDERR: 27  0x7fdb3475772f void std::_Bind<void (WebCore::MainThreadSharedTimer::*(WebCore::MainThreadSharedTimer*))()>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>)
STDERR: 28  0x7fdb347576c1 void std::_Bind<void (WebCore::MainThreadSharedTimer::*(WebCore::MainThreadSharedTimer*))()>::operator()<, void>()
STDERR: 29  0x7fdb3475768a WTF::Detail::CallableWrapper<std::_Bind<void (WebCore::MainThreadSharedTimer::*(WebCore::MainThreadSharedTimer*))()>, void>::call()
STDERR: 30  0x7fdb2ba697ed WTF::Function<void ()>::operator()() const
STDERR: 31  0x7fdb2c0624d8 WTF::RunLoop::Timer::fired()

[Claudio Saavedra]

Gardened in https://commits.webkit.org/286285@main

[Radar WebKit Bug Importer]

<rdar://problem/139882601>

[Chris Dumez]

We can unskip this. I fixed the crash a while back.

[Chris Dumez]

Pull request: https://github.com/WebKit/WebKit/pull/38298

[EWS]

Committed 288210@main (827a7a112e2d): <https://commits.webkit.org/288210@main>

Reviewed commits have been landed. Closing PR #38298 and removing active labels.