Bug 282754 – [macOS wk2 x86_64 ] 2 tests in imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes are a constant failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

<rdar://139405428>

[zalan]

Created attachment 473166 [details]
Patch

[zalan]

Created attachment 473167 [details]
[fast-cq]Patch

[Simon Fraser (smfr)]

Comment on attachment 473167 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=473167&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-022.html:13
> +  <meta name="fuzzy" content="maxDifference=2; totalPixels=1" />

You want 0-2 and 0-1

> LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-025.html:13
> +  <meta name="fuzzy" content="maxDifference=2; totalPixels=1" />

Ditto

[zalan]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 473167 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=473167&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-022.html:13
> > +  <meta name="fuzzy" content="maxDifference=2; totalPixels=1" />
> 
> You want 0-2 and 0-1
I think (and correct me if I'm wrong) 0-2 also includes the max-difference of 1 which is never the case (at lease not currently) while 2 means 0 and 2 which is a more accurate representation of what's failing here.

[EWS]

Committed 286330@main (ffd140a12a74): <https://commits.webkit.org/286330@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 473167 [details].

[Tim Nguyen (:ntim)]

(In reply to zalan from comment #4)
> (In reply to Simon Fraser (smfr) from comment #3)
> > Comment on attachment 473167 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=473167&action=review
> > 
> > > LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-022.html:13
> > > +  <meta name="fuzzy" content="maxDifference=2; totalPixels=1" />
> > 
> > You want 0-2 and 0-1
> I think (and correct me if I'm wrong) 0-2 also includes the max-difference
> of 1 which is never the case (at lease not currently) while 2 means 0 and 2
> which is a more accurate representation of what's failing here.

0-2 / 0-1 is correct, 2/1 will strictly match and cause the test to fail in other browsers if they 100% match.