Bug 28275 - media/video-played.html always times out on Windows
Summary: media/video-played.html always times out on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Eric Carlson
URL: http://build.webkit.org/results/Windo...
Keywords: InRadar, LayoutTestFailure, PlatformOnly
Depends on:
Blocks:
 
Reported: 2009-08-13 13:16 PDT by Adam Roben (:aroben)
Modified: 2009-08-14 15:17 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (27.14 KB, patch)
2009-08-14 09:56 PDT, Eric Carlson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-08-13 13:16:27 PDT
To reproduce:

1. run-webkit-tests --debug media/video-played.html

The test always times out in Debug builds. Maybe it needs to be split up to make it take less time?
Comment 1 Adam Roben (:aroben) 2009-08-13 13:19:46 PDT
Looks like it times out in Release builds, too: http://build.webkit.org/results/Windows%20Release%20(Tests)/r47216%20(3350)/media/video-played-pretty-diff.html
Comment 2 Adam Roben (:aroben) 2009-08-13 13:20:12 PDT
<rdar://problem/7141132>
Comment 3 Eric Carlson 2009-08-14 09:56:26 PDT
Created attachment 34850 [details]
proposed patch
Comment 4 Simon Fraser (smfr) 2009-08-14 10:49:57 PDT
Comment on attachment 34850 [details]
proposed patch

> +//@@@@@ Uncomment the following line to log the time each "video-played" sub-test takes in test output
> +//@@@@@ logTestTiming = true;

Weird comment style.
Comment 5 Eric Carlson 2009-08-14 11:03:35 PDT
>> +//@@@@@ Uncomment the following line to log the time each "video-played" sub-test takes in test output
>> +//@@@@@ logTestTiming = true;

>Weird comment style.

Yes, I did that purposely so it stands out visually for someone reading it later. Understanding a failure in one of these tests is almost impossible without extra the logging so I wanted to make this debugging tool obvious.
Comment 6 Eric Carlson 2009-08-14 11:05:32 PDT
http://trac.webkit.org/changeset/47287