WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282724
Avoid unnecessary conversions from ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=282724
Summary
Avoid unnecessary conversions from ASCIILiteral
Brent Fulgham
Reported
2024-11-06 16:00:16 PST
Over the years of refactoring, we've wrapped immutable ASCIILiterals in strings at various points. We should try to pass the basic type when possible to avoid constructing a String object unless it is needed.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-11-06 16:53:45 PST
<
rdar://problem/139394432
>
Brent Fulgham
Comment 2
2024-11-06 16:57:40 PST
Pull request:
https://github.com/WebKit/WebKit/pull/36299
EWS
Comment 3
2024-11-08 15:21:15 PST
Committed
286364@main
(78bc243d1e64): <
https://commits.webkit.org/286364@main
> Reviewed commits have been landed. Closing PR #36299 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug