WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282719
Switch logical box properties to WritingMode instead of RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=282719
Summary
Switch logical box properties to WritingMode instead of RenderStyle
fantasai
Reported
2024-11-06 14:49:49 PST
RenderStyle and RenderBoxModelObject have a number of methods that map margin/border/padding from logical to physical. We should use a WritingMode object as the argument for these instead of RenderStyle, which is more efficient and also will allow easier use of these properties throughout the codebase.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-11-06 14:50:17 PST
<
rdar://problem/139386989
>
fantasai
Comment 2
2024-11-06 15:01:34 PST
Pull request:
https://github.com/WebKit/WebKit/pull/36290
EWS
Comment 3
2024-11-14 12:06:17 PST
Committed
286604@main
(ee545145e8f9): <
https://commits.webkit.org/286604@main
> Reviewed commits have been landed. Closing PR #36290 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug