WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282679
Build failure: -[PDFSelection {html, webArchive}] is deprecated in certain SDKs
https://bugs.webkit.org/show_bug.cgi?id=282679
Summary
Build failure: -[PDFSelection {html, webArchive}] is deprecated in certain SDKs
Abrar Rahman Protyasha
Reported
2024-11-06 02:00:44 PST
These methods are deprecated in certain SDKs, so building WebKit against said versions produces the forthcoming error: ``` In file included from /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/DerivedSources/WebKit/unified-sources/UnifiedSource70-mm.mm:2: /Volumes/Data/WebKit/OpenSource/Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:2629:54: error: 'webArchive' is deprecated: first deprecated in macOS 13.0 - Unsupported, returns nil [-Werror,-Wdeprecated-declarations] 2629 | if (NSData *webArchiveData = [m_currentSelection webArchive]) { In file included from /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/DerivedSources/WebKit/unified-sources/UnifiedSource70-mm.mm:2: In file included from /Volumes/Data/WebKit/OpenSource/Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:38: In file included from /Volumes/Data/WebKit/OpenSource/Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h:41: /my/sdk/path/System/Library/Frameworks/PDFKit.framework/PrivateHeaders/PDFSelectionPriv.h:73:1: note: 'webArchive' has been explicitly marked deprecated here 73 | - (nullable NSData *) webArchive In file included from /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/DerivedSources/WebKit/unified-sources/UnifiedSource70-mm.mm:2: /Volumes/Data/WebKit/OpenSource/Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:2639:55: error: 'html' is deprecated: first deprecated in macOS 13.0 - Use htmlData instead [-Werror,-Wdeprecated-declarations] 2639 | if (NSData *htmlStringData = [[m_currentSelection html] dataUsingEncoding:NSUTF8StringEncoding]) { In file included from /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/DerivedSources/WebKit/unified-sources/UnifiedSource70-mm.mm:2: In file included from /Volumes/Data/WebKit/OpenSource/Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:38: In file included from /Volumes/Data/WebKit/OpenSource/Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h:41: /my/sdk/path/System/Library/Frameworks/PDFKit.framework/PrivateHeaders/PDFSelectionPriv.h:71:1: note: 'html' has been explicitly marked deprecated here 71 | - (nullable NSString *) html ```
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-11-06 02:01:09 PST
<
rdar://problem/139343962
>
Abrar Rahman Protyasha
Comment 2
2024-11-06 02:09:37 PST
Pull request:
https://github.com/WebKit/WebKit/pull/36252
EWS
Comment 3
2024-11-06 03:29:07 PST
Committed
286217@main
(2e5a1a1dc7af): <
https://commits.webkit.org/286217@main
> Reviewed commits have been landed. Closing PR #36252 and removing active labels.
David Kilzer (:ddkilzer)
Comment 4
2024-11-21 17:18:38 PST
<
rdar://problem/140380909
>
EWS
Comment 5
2024-11-22 03:08:19 PST
Committed
283286.527@safari-7620-branch
(8ade047f9f0b): <
https://commits.webkit.org/283286.527@safari-7620-branch
> Reviewed commits have been landed. Closing PR #2339 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug