WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282638
[css-masonry] Refactor Overriding of Logical Width during Masonry
https://bugs.webkit.org/show_bug.cgi?id=282638
Summary
[css-masonry] Refactor Overriding of Logical Width during Masonry
Brandon
Reported
2024-11-05 13:58:06 PST
The overriding logical width logic should live in the GridMasonryLayout instead of RenderGrid. Added an enum to handle the different min, max, and not overriding cases. There was one special behavior with subgrid containers not being iterated over in the old implementation. I added extra code to handle this behavior.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-11-05 13:58:22 PST
<
rdar://problem/139312026
>
Brandon
Comment 2
2024-11-05 14:00:25 PST
Pull request:
https://github.com/WebKit/WebKit/pull/36215
EWS
Comment 3
2024-11-07 06:29:45 PST
Committed
286276@main
(578b0cd616d2): <
https://commits.webkit.org/286276@main
> Reviewed commits have been landed. Closing PR #36215 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug