Bug 28263 - Add support for Fedora distros in the http tests
Summary: Add support for Fedora distros in the http tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-13 09:43 PDT by Xan Lopez
Modified: 2009-09-01 05:51 PDT (History)
0 users

See Also:

Attachments
httpdconf.patch (38.73 KB, patch)
2009-08-13 09:48 PDT, Xan Lopez 		no flags Details | Formatted Diff | Diff
fedorahttpd.patch (34.78 KB, patch)
2009-08-26 05:13 PDT, Xan Lopez 		gustavo: review+
gustavo: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2009-08-13 09:43:53 PDT 
Subject says it all, add the needed detection code and a working conf file.
Comment 1 Xan Lopez 2009-08-13 09:48:15 PDT 
Created attachment 34751 [details]
httpdconf.patch

Add support for Fedora in http tests that use Apache.
Comment 2 Eric Seidel (no email) 2009-08-13 10:07:25 PDT 
Comment on attachment 34751 [details]
httpdconf.patch

It's very sad that our apache conf files are just copy/paste of one another.  I would think we could share a lot more code between them. :(
Comment 3 Xan Lopez 2009-08-26 05:12:35 PDT 
(In reply to comment #2)
> (From update of attachment 34751 [details])
> It's very sad that our apache conf files are just copy/paste of one another.  I
> would think we could share a lot more code between them. :(

So... I can agree with the sentiment here, but it kind of sucks to block this because of that now that there's already a lot of httpd.conf files in the tree :/

Adding the latest revision of the patch.
Comment 4 Xan Lopez 2009-08-26 05:13:21 PDT 
Created attachment 38605 [details]
fedorahttpd.patch

httpd support for Fedora.
Comment 5 Gustavo Noronha (kov) 2009-09-01 05:43:51 PDT 
Comment on attachment 38605 [details]
fedorahttpd.patch

Yep!
Comment 6 Xan Lopez 2009-09-01 05:51:10 PDT 
Landed in r47930, closing.