WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
282625
[resultsdbpy] Fix _find() method in commit_controller.py return amount to abide by the limit amount passed.
https://bugs.webkit.org/show_bug.cgi?id=282625
Summary
[resultsdbpy] Fix _find() method in commit_controller.py return amount to abi...
Anfernee Viduya
Reported
2024-11-05 11:00:39 PST
ISSUE: Right now when invoking _find() method in commit_controller.py with an explicit limit argument it returns the (limit*amount_of_repositories) amount. This only works if amount_of_repositories = 1. (e.g.) ''' LIMIT = 1000 def _find(LIMIT): ... commits*amount_of_repositories return sorted(list(commits)) ''' FIX: Slice the list that was returned outside the 'sorted()' method (e.g.) ''' LIMIT = 1000 def _find(LIMIT): .... commits*amount_of_repositories return sorted(list(commits))[:limit] '''
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-11-05 11:00:49 PST
<
rdar://problem/139298383
>
Anfernee Viduya
Comment 2
2024-11-05 11:38:10 PST
Pull request:
https://github.com/WebKit/WebKit/pull/36206
EWS
Comment 3
2024-11-05 13:07:54 PST
Committed
286184@main
(74589224e4a9): <
https://commits.webkit.org/286184@main
> Reviewed commits have been landed. Closing PR #36206 and removing active labels.
Ben Schwartz
Comment 4
2024-11-05 18:01:05 PST
Reopened Bugzilla. Unreviewed revert of
286184@main
, broke tooling., tracking revert in
https://bugs.webkit.org/show_bug.cgi?id=282666
.
Anfernee Viduya
Comment 5
2024-11-06 10:34:47 PST
Pull request:
https://github.com/WebKit/WebKit/pull/36267
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug