RESOLVED FIXED 28261
REGRESSION(r47175): error running run-webkit-tests 
https://bugs.webkit.org/show_bug.cgi?id=28261
Summary REGRESSION(r47175): error running run-webkit-tests
Eric Seidel (no email)
Reported 2009-08-13 09:30:57 PDT
Use of uninitialized value in concatenation (.) or string at WebKitTools/Scripts/run-webkit-tests line 191. I have a fix.
Attachments
Patch v1 (1.36 KB, patch)
2009-08-13 09:32 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-08-13 09:32:49 PDT
Created attachment 34750 [details] Patch v1
Eric Seidel (no email)
Comment 2 2009-08-13 09:33:31 PDT
It was being used in the $usage string before being set.
Eric Seidel (no email)
Comment 3 2009-08-13 10:59:33 PDT
Comment on attachment 34750 [details] Patch v1 Rejecting patch 34750 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None
David Kilzer (:ddkilzer)
Comment 4 2009-08-13 11:00:22 PDT
(In reply to comment #0) > Use of uninitialized value in concatenation (.) or string at > WebKitTools/Scripts/run-webkit-tests line 191. *sigh* I should just stop working on tools. My record hasn't been very good recently.
Eric Seidel (no email)
Comment 5 2009-08-13 11:01:55 PDT
Comment on attachment 34750 [details] Patch v1 Sigh. a checkin happend right as bugzilla-tool was about to land this. adding it back to the queue.
Eric Seidel (no email)
Comment 6 2009-08-13 11:02:34 PDT
(In reply to comment #4) > (In reply to comment #0) > > Use of uninitialized value in concatenation (.) or string at > > WebKitTools/Scripts/run-webkit-tests line 191. > > *sigh* I should just stop working on tools. My record hasn't been very good > recently. I would be very sad were that to be the case! We just need to get you hackin on the python stuff which is actually unit-testable. :)
Eric Seidel (no email)
Comment 7 2009-08-13 11:14:01 PDT
Comment on attachment 34750 [details] Patch v1 Rejecting patch 34750 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None
Eric Seidel (no email)
Comment 8 2009-08-13 11:35:03 PDT
Comment on attachment 34750 [details] Patch v1 Clearing flags on attachment: 34750 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests Committed r47223 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r47223 = f1aeff7782adc69b65427803575711023b57ada0 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47223
Eric Seidel (no email)
Comment 9 2009-08-13 11:35:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.