WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282535
[WPE][GTK][WTF] Add support for tracing counters with Sysprof
https://bugs.webkit.org/show_bug.cgi?id=282535
Summary
[WPE][GTK][WTF] Add support for tracing counters with Sysprof
Georges Basile Stavracas Neto
Reported
2024-11-04 05:55:26 PST
This allows e.g. monitoring how many buffers are on flight, or the FPS over time.
Attachments
Add attachment
proposed patch, testcase, etc.
Georges Basile Stavracas Neto
Comment 1
2024-11-04 06:05:16 PST
Pull request:
https://github.com/WebKit/WebKit/pull/36123
EWS
Comment 2
2025-04-01 10:58:41 PDT
Committed
293020@main
(e812b451c525): <
https://commits.webkit.org/293020@main
> Reviewed commits have been landed. Closing PR #36123 and removing active labels.
Diego Pino
Comment 3
2025-04-02 02:26:42 PDT
The patch caused a build error on Debian and Ubuntu post-commit bots:
https://build.webkit.org/#/builders/46/builds/49508
``` from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:56, from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-9.cpp:7: /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WTF/Headers/wtf/glib/SysprofAnnotator.h: In member function ‘void WTF::SysprofAnnotator::setCounter(std::span<const char>, int64_t)’: /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WTF/Headers/wtf/glib/SysprofAnnotator.h:265:13: error: ‘strlcpy’ was not declared in this scope; did you mean ‘strncpy’? 265 | strlcpy(counter.category, m_processName.characters(), sizeof counter.category); | ^~~~~~~ ```
Diego Pino
Comment 4
2025-04-02 02:33:24 PDT
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/43453
EWS
Comment 5
2025-04-02 02:59:07 PDT
Committed
293090@main
(37790f401c18): <
https://commits.webkit.org/293090@main
> Reviewed commits have been landed. Closing PR #43453 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug