WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282458
[webkitpy] SimulatedDeviceManager.initialize_devices is not preferring booted simulators.
https://bugs.webkit.org/show_bug.cgi?id=282458
Summary
[webkitpy] SimulatedDeviceManager.initialize_devices is not preferring booted...
Ben Schwartz
Reported
2024-11-01 13:30:39 PDT
The changes at
285830@main
added support for specifying the UDID(s) of the desired simulators to use when invoking run-webkit-tests. As part of this change, the flow of choosing which device to use changed to be: 1) explicitly requested by user (--udid flag), 2) already booted, 3) already created non-booted, and 4) create new. A logical error caused booted devices not to be preferred, favoring the devices in alphabetical order instead. This should be changed to reflect the desired behavior.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-11-01 13:31:52 PDT
<
rdar://problem/139092301
>
Ben Schwartz
Comment 2
2024-11-01 13:38:24 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/36059
EWS
Comment 3
2024-11-01 17:12:50 PDT
Committed
286040@main
(3dc7935d008b): <
https://commits.webkit.org/286040@main
> Reviewed commits have been landed. Closing PR #36059 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug