REOPENED282406
Enable -Wunsafe-buffer-usage in WebCore 
https://bugs.webkit.org/show_bug.cgi?id=282406
Summary Enable -Wunsafe-buffer-usage in WebCore
Geoffrey Garen
Reported 2024-10-31 13:24:19 PDT
...
Attachments
Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2024-10-31 13:24:21 PDT
<rdar://problem/137810622>
Geoffrey Garen
Comment 2 2024-10-31 13:25:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/36014
EWS
Comment 3 2024-11-01 16:18:16 PDT
Committed 286031@main (67602317a964): <https://commits.webkit.org/286031@main> Reviewed commits have been landed. Closing PR #36014 and removing active labels.
Ryosuke Niwa
Comment 4 2024-11-01 19:12:48 PDT
Looks like this broke builds on safer C++ bots? Source/WebCore/crypto/cocoa/CryptoAlgorithmEd25519Cocoa.cpp:54:28: error: the two-parameter std::span construction is unsafe as it can introduce mismatch between buffer size and the bound information [-Werror,-Wunsafe-buffer-usage-in-container] 54 | return Vector<uint8_t>(std::span { newSignature, ed25519SignatureSize }); | ^ error: unsafe pointer operation [-Werror,-Wunsafe-buffer-usage] note: pass -fsafe-buffer-usage-suggestions to receive code hardening suggestions 2 errors generated.
Geoffrey Garen
Comment 5 2024-11-01 19:21:30 PDT
Oh, that must be the #if !HAVE(SWIFT_CPP_INTEROP) config. Fixing....
Geoffrey Garen
Comment 6 2024-11-01 20:07:42 PDT
Trying out a fix in https://github.com/WebKit/WebKit/pull/36082
Jonathan Bedard
Comment 7 2024-11-02 14:23:58 PDT
Reopened Bugzilla. REGRESSION(286031@main): Broke Internal iOS and visionOS Debug builds, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=282497.
Note You need to log in before you can comment on or make changes to this bug.