RESOLVED FIXED 28239
bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode 
https://bugs.webkit.org/show_bug.cgi?id=28239
Summary bugzilla-tool land-patches rejects patches from the commit-queue when not in ...
Eric Seidel (no email)
Reported 2009-08-12 16:49:57 PDT
bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode It should not cq- minus patches when not in commit-queue mode.
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-08-12 20:04:11 PDT
Sorry. I should caught that when reviewing the earlier change.
Eric Seidel (no email)
Comment 2 2009-10-23 16:37:22 PDT
I'm not sure which circumstances produce this bug, making it difficult to fix. Should patches not be cq-'d when a build fails and you're not in commit mode? If not, we just need to conditionalize: except ScriptError, e: # Mark the patch as commit-queue- and comment in the bug. tool.bugs.reject_patch_from_commit_queue(patch['id'], e.message_with_output()) error(e) in LandPatchesFromBugs.land_patches
Eric Seidel (no email)
Comment 3 2010-01-19 16:42:23 PST
I've not seen this in a long time.
Note You need to log in before you can comment on or make changes to this bug.