Bug 28233 - Added symbian specific UID3 identifiers to project files
Summary: Added symbian specific UID3 identifiers to project files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-12 14:39 PDT by Norbert Leser
Modified: 2009-08-13 09:23 PDT (History)
4 users (show)

See Also:

Attachments
Symbian UID3 Patch for .pro files (5.10 KB, patch)
2009-08-12 14:39 PDT, Norbert Leser 		eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
Updated patch for bug #28233 (4.87 KB, patch)
2009-08-13 04:45 PDT, Norbert Leser 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Norbert Leser 2009-08-12 14:39:44 PDT 
Created attachment 34694 [details]
Symbian UID3 Patch for .pro files

Symbian target components (library and executable files) require Unique Identifiers (i.e., UID3). These identifiers are defined in the respective project files, conditionally for "symbian" platform.

Also, 2 additional properties need to be specified for the QtLauncher executable in the project file, conditionally for "symbian".
Comment 1 Eric Seidel (no email) 2009-08-12 16:20:04 PDT 
Comment on attachment 34694 [details]
Symbian UID3 Patch for .pro files

You don't describe these very well:
+        Also, 2 additional properties need to be specified
+        for the QtLauncher executable in the project file,
+        conditionally for "symbian".

The patch looks non-harmful though.
Comment 2 Eric Seidel (no email) 2009-08-12 17:00:47 PDT 
Comment on attachment 34694 [details]
Symbian UID3 Patch for .pro files

Rejecting patch 34694 from commit-queue.  This patch will require manual commit.

WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet --exit-after-n-failures=1 failed with exit code 1
Comment 3 Norbert Leser 2009-08-13 04:45:28 PDT 
Created attachment 34731 [details]
Updated patch for bug #28233

Cleanup of previous patch. Removed non-UID3 related changes in QtLauncher.pro (were redundant and not mandatory), and added missing new line.
Comment 4 Simon Hausmann 2009-08-13 04:51:59 PDT 
Comment on attachment 34731 [details]
Updated patch for bug #28233

r=me
Comment 5 Eric Seidel (no email) 2009-08-13 09:23:06 PDT 
Comment on attachment 34731 [details]
Updated patch for bug #28233

Clearing flags on attachment: 34731

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.pro
	M	WebKit/qt/ChangeLog
	M	WebKit/qt/QtLauncher/QtLauncher.pro
	M	WebKit/qt/tests/qwebelement/qwebelement.pro
	M	WebKit/qt/tests/qwebframe/qwebframe.pro
	M	WebKit/qt/tests/qwebhistory/qwebhistory.pro
	M	WebKit/qt/tests/qwebhistoryinterface/qwebhistoryinterface.pro
	M	WebKit/qt/tests/qwebpage/qwebpage.pro
	M	WebKit/qt/tests/qwebview/qwebview.pro
Committed r47201
	M	WebKit/qt/tests/qwebhistory/qwebhistory.pro
	M	WebKit/qt/tests/qwebhistoryinterface/qwebhistoryinterface.pro
	M	WebKit/qt/tests/qwebelement/qwebelement.pro
	M	WebKit/qt/tests/qwebframe/qwebframe.pro
	M	WebKit/qt/tests/qwebview/qwebview.pro
	M	WebKit/qt/tests/qwebpage/qwebpage.pro
	M	WebKit/qt/QtLauncher/QtLauncher.pro
	M	WebKit/qt/ChangeLog
	M	WebCore/WebCore.pro
	M	WebCore/ChangeLog
r47201 = c57498b37dbdc9cf8d4b6da4f1bbb21dba5600ec (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47201
Comment 6 Eric Seidel (no email) 2009-08-13 09:23:11 PDT 
All reviewed patches have been landed.  Closing bug.