Bug 28233 – Added symbian specific UID3 identifiers to project files

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Norbert Leser]

Created attachment 34694 [details]
Symbian UID3 Patch for .pro files

Symbian target components (library and executable files) require Unique Identifiers (i.e., UID3). These identifiers are defined in the respective project files, conditionally for "symbian" platform.

Also, 2 additional properties need to be specified for the QtLauncher executable in the project file, conditionally for "symbian".

[Eric Seidel (no email)]

Comment on attachment 34694 [details]
Symbian UID3 Patch for .pro files

You don't describe these very well:
+        Also, 2 additional properties need to be specified
+        for the QtLauncher executable in the project file,
+        conditionally for "symbian".

The patch looks non-harmful though.

[Eric Seidel (no email)]

Comment on attachment 34694 [details]
Symbian UID3 Patch for .pro files

Rejecting patch 34694 from commit-queue.  This patch will require manual commit.

WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet --exit-after-n-failures=1 failed with exit code 1

[Norbert Leser]

Created attachment 34731 [details]
Updated patch for bug #28233

Cleanup of previous patch. Removed non-UID3 related changes in QtLauncher.pro (were redundant and not mandatory), and added missing new line.

[Simon Hausmann]

Comment on attachment 34731 [details]
Updated patch for bug #28233

r=me

[Eric Seidel (no email)]

Comment on attachment 34731 [details]
Updated patch for bug #28233

Clearing flags on attachment: 34731

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.pro
	M	WebKit/qt/ChangeLog
	M	WebKit/qt/QtLauncher/QtLauncher.pro
	M	WebKit/qt/tests/qwebelement/qwebelement.pro
	M	WebKit/qt/tests/qwebframe/qwebframe.pro
	M	WebKit/qt/tests/qwebhistory/qwebhistory.pro
	M	WebKit/qt/tests/qwebhistoryinterface/qwebhistoryinterface.pro
	M	WebKit/qt/tests/qwebpage/qwebpage.pro
	M	WebKit/qt/tests/qwebview/qwebview.pro
Committed r47201
	M	WebKit/qt/tests/qwebhistory/qwebhistory.pro
	M	WebKit/qt/tests/qwebhistoryinterface/qwebhistoryinterface.pro
	M	WebKit/qt/tests/qwebelement/qwebelement.pro
	M	WebKit/qt/tests/qwebframe/qwebframe.pro
	M	WebKit/qt/tests/qwebview/qwebview.pro
	M	WebKit/qt/tests/qwebpage/qwebpage.pro
	M	WebKit/qt/QtLauncher/QtLauncher.pro
	M	WebKit/qt/ChangeLog
	M	WebCore/WebCore.pro
	M	WebCore/ChangeLog
r47201 = c57498b37dbdc9cf8d4b6da4f1bbb21dba5600ec (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47201

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.