Bug 28228 – Add WebkitDOMObject header files

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKitGTK

[Gour]

Adds header files for WebkitDOMObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=27428
Is part of gobject.

[Gour]

Created attachment 34688 [details]
uploadded

[Gour]

Comment on attachment 34688 [details]
uploadded

I am cancelling the review because it has the same problem as #27428.

[Mark Rowe (bdash)]

Gour, rather than continuing along with the same problematic approach that Luke took can you please do as requested and discuss a more productive approach with the maintainers of the GTK port.

[Gour]

(In reply to comment #3)
> Gour, rather than continuing along with the same problematic approach that Luke
> took can you please do as requested and discuss a more productive approach with
> the maintainers of the GTK port.

OK. I'm just trying to take over from where Luke was blocked to contribute...

[Gour]

(In reply to comment #4)
> (In reply to comment #3)
> > Gour, rather than continuing along with the same problematic approach that Luke
> > took can you please do as requested and discuss a more productive approach with
> > the maintainers of the GTK port.

OK. What should i do?

I am not as experienced as lkcl but i am willing to learn, please do advise me what I should do, and where should i contact the gtk developers?

[Xan Lopez]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Gour, rather than continuing along with the same problematic approach that Luke
> > > took can you please do as requested and discuss a more productive approach with
> > > the maintainers of the GTK port.
> 
> OK. What should i do?
> 
> I am not as experienced as lkcl but i am willing to learn, please do advise me
> what I should do, and where should i contact the gtk developers?

First read https://bugs.webkit.org/show_bug.cgi?id=16401. Yes, it's long, but hopefully when you are done you'll see how important is to avoid to keep falling into this abyss over and over again.

After that, I (and I think I talk for all GTK maintainers here) still think that the way to go was already stated clearly in comment #194 (https://bugs.webkit.org/show_bug.cgi?id=16401#c194) in that bug:

"I concur with Mark's review, this is not ready to be landed.  I have gone
through the CodeGenerator and picked out a bunch of issues that really stick
out, but in general, I can't really review this as is.  I believe the best way
forward is for you to pick one file (say Node.idl) and get code generation
working for it or a subset of it.  The stripped down version of the code
generator that can generate this one file will be a great jumping off point.  I
know this seems like a step backwards, but the current state of the patch is
really not reviewable as is due to a lack of clarity in the code."

So if you want to get into this, I suggest you try to start doing something like that, and see where we get from there.

hello, 

my english is not the best... so i didn't know whats wrong with this patch? how can i help, to bring bug #16401 forward?

greetings

[Anders Carlsson]

This doesn't need to be open.