Bug 28228 - Add WebkitDOMObject header files
Summary: Add WebkitDOMObject header files
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 27428
Blocks: 16401
  Show dependency treegraph
 
Reported: 2009-08-12 14:12 PDT by Gour
Modified: 2014-01-31 19:02 PST (History)
3 users (show)

See Also:


Attachments
uploadded (4.47 KB, patch)
2009-08-12 14:14 PDT, Gour
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gour 2009-08-12 14:12:29 PDT
Adds header files for WebkitDOMObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=27428
Is part of gobject.
Comment 1 Gour 2009-08-12 14:14:28 PDT
Created attachment 34688 [details]
uploadded
Comment 2 Gour 2009-08-12 14:17:05 PDT
Comment on attachment 34688 [details]
uploadded

I am cancelling the review because it has the same problem as #27428.
Comment 3 Mark Rowe (bdash) 2009-08-12 15:30:23 PDT
Gour, rather than continuing along with the same problematic approach that Luke took can you please do as requested and discuss a more productive approach with the maintainers of the GTK port.
Comment 4 Gour 2009-08-13 03:12:11 PDT
(In reply to comment #3)
> Gour, rather than continuing along with the same problematic approach that Luke
> took can you please do as requested and discuss a more productive approach with
> the maintainers of the GTK port.

OK. I'm just trying to take over from where Luke was blocked to contribute...
Comment 5 Gour 2009-08-13 03:18:15 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > Gour, rather than continuing along with the same problematic approach that Luke
> > took can you please do as requested and discuss a more productive approach with
> > the maintainers of the GTK port.

OK. What should i do?

I am not as experienced as lkcl but i am willing to learn, please do advise me what I should do, and where should i contact the gtk developers?
Comment 6 Xan Lopez 2009-08-13 03:52:26 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Gour, rather than continuing along with the same problematic approach that Luke
> > > took can you please do as requested and discuss a more productive approach with
> > > the maintainers of the GTK port.
> 
> OK. What should i do?
> 
> I am not as experienced as lkcl but i am willing to learn, please do advise me
> what I should do, and where should i contact the gtk developers?

First read https://bugs.webkit.org/show_bug.cgi?id=16401. Yes, it's long, but hopefully when you are done you'll see how important is to avoid to keep falling into this abyss over and over again.

After that, I (and I think I talk for all GTK maintainers here) still think that the way to go was already stated clearly in comment #194 (https://bugs.webkit.org/show_bug.cgi?id=16401#c194) in that bug:

"I concur with Mark's review, this is not ready to be landed.  I have gone
through the CodeGenerator and picked out a bunch of issues that really stick
out, but in general, I can't really review this as is.  I believe the best way
forward is for you to pick one file (say Node.idl) and get code generation
working for it or a subset of it.  The stripped down version of the code
generator that can generate this one file will be a great jumping off point.  I
know this seems like a step backwards, but the current state of the patch is
really not reviewable as is due to a lack of clarity in the code."

So if you want to get into this, I suggest you try to start doing something like that, and see where we get from there.
Comment 7 sascha.dewald 2009-12-12 08:00:28 PST
hello, 

my english is not the best... so i didn't know whats wrong with this patch? how can i help, to bring bug #16401 forward?

greetings
Comment 8 Anders Carlsson 2014-01-31 19:02:27 PST
This doesn't need to be open.