WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282274
[GStreamer] VideoSinkCommon: Do not handle events while flushing
https://bugs.webkit.org/show_bug.cgi?id=282274
Summary
[GStreamer] VideoSinkCommon: Do not handle events while flushing
Alicia Boya García
Reported
2024-10-29 13:29:25 PDT
WebKitVideoSinkProbe has checks for a number of events, namely tag, allocation and drain. Events must not be processed during flushes (doing it anyway is a common source of deadlocks, for example), but there was no check to prevent that. This patch adds that. This is a preventive correctness fix and not motivated by any particular error report. * Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp: (WebKitVideoSinkProbe::doProbe):
Attachments
Add attachment
proposed patch, testcase, etc.
Alicia Boya García
Comment 1
2024-10-30 11:03:40 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35951
EWS
Comment 2
2024-10-31 09:41:06 PDT
Committed
285957@main
(6085aa83ce72): <
https://commits.webkit.org/285957@main
> Reviewed commits have been landed. Closing PR #35951 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug