Bug 282197 – Update autoinstalled cffi

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Michael Catanzaro]

There are a huge number of warnings when autoinstalling cffi, which fails to build its wheel on Fedora 41 due to -Werror=implicit-function-declaration. Let's update it. I've pasted only one copy of the warnings below, but they all print five times when running 'git-webkit pr'. I guess the script repeats its attempt to install cffi many times. But git-webkit seems to work just fine nevertheless, though.

Downloading cffi-1.15.1...
Installing cffi-1.15.1...
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/setuptools/config/setupcfg.py:293: _DeprecatedConfig: Deprecated config in `setup.cfg`
!!

        ********************************************************************************
        The license_file parameter is deprecated, use license_files instead.

        This deprecation is overdue, please update your project and remove deprecated
        calls to avoid build errors in the future.

        See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
        ********************************************************************************

!!
  parsed = self.parsers.get(option_name, lambda x: x)(value)
running install
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` directly.
        Instead, use pypa/build, pypa/installer or other
        standards-based tools.

        See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
        ********************************************************************************

!!
  self.initialize_options()
running build
running build_py
creating build
creating build/lib.linux-x86_64-cpython-313
creating build/lib.linux-x86_64-cpython-313/cffi
copying cffi/__init__.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/api.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/backend_ctypes.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/cffi_opcode.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/commontypes.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/cparser.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/error.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/ffiplatform.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/lock.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/model.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/pkgconfig.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/recompiler.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/setuptools_ext.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/vengine_cpy.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/vengine_gen.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/verifier.py -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/_cffi_include.h -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/parse_c_type.h -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/_embedding.h -> build/lib.linux-x86_64-cpython-313/cffi
copying cffi/_cffi_errors.h -> build/lib.linux-x86_64-cpython-313/cffi
running build_ext
building '_cffi_backend' extension
creating build/temp.linux-x86_64-cpython-313
creating build/temp.linux-x86_64-cpython-313/c
gcc -fno-strict-overflow -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -fexceptions -fcf-protection -fexceptions -fcf-protection -fexceptions -fcf-protection -O3 -fPIC -DFFI_BUILDING=1 -DUSE__THREAD -DHAVE_SYNC_SYNCHRONIZE -I/usr/include/python3.13 -c c/_cffi_backend.c -o build/temp.linux-x86_64-cpython-313/c/_cffi_backend.o
c/_cffi_backend.c: In function ‘b_do_dlopen’:
c/_cffi_backend.c:4523:22: warning: ‘Py_FileSystemDefaultEncoding’ is deprecated [-Wdeprecated-declarations]
 4523 |                      Py_FileSystemDefaultEncoding, &filename_or_null, &flags))
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/python3.13/Python.h:99,
                 from c/_cffi_backend.c:2:
/usr/include/python3.13/fileobject.h:22:46: note: declared here
   22 | Py_DEPRECATED(3.12) PyAPI_DATA(const char *) Py_FileSystemDefaultEncoding;
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
c/_cffi_backend.c: In function ‘_my_PyErr_WriteUnraisable’:
c/_cffi_backend.c:6112:9: error: implicit declaration of function ‘_PyErr_WriteUnraisableMsg’; did you mean ‘PyErr_WriteUnraisable’? [-Wimplicit-function-declaration]
 6112 |         _PyErr_WriteUnraisableMsg(PyText_AS_UTF8(s), NULL);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
      |         PyErr_WriteUnraisable
error: command '/usr/lib64/ccache/gcc' failed with exit code 1
Failed to install cffi-1.15.1!
ERROR:keyring.backend:Error initializing plugin EntryPoint(name='SecretService', value='keyring.backends.SecretService', group='keyring.backends').
Traceback (most recent call last):
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/keyring/backend.py", line 201, in _load_plugins
    init_func = ep.load()
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/importlib_metadata/__init__.py", line 194, in load
    module = import_module(match.group('module'))
  File "/usr/lib64/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1022, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/keyring/backends/SecretService.py", line 15, in <module>
    import secretstorage
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/secretstorage/__init__.py", line 13, in <module>
    from secretstorage.collection import Collection, create_collection, \
     get_all_collections, get_default_collection, get_any_collection, \
     get_collection_by_alias, search_items
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/secretstorage/collection.py", line 24, in <module>
    from secretstorage.item import Item
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/secretstorage/item.py", line 17, in <module>
    from secretstorage.util import DBusAddressWrapper, \
     exec_prompt, open_session, format_secret, unlock_objects
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/secretstorage/util.py", line 23, in <module>
    from cryptography.hazmat.primitives.ciphers import Cipher, algorithms, modes
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1322, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1262, in _find_spec
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 699, in find_spec
    loader = cls.find_module(fullname, path=path)
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 713, in find_module
    cls.install(name)
    ~~~~~~~~~~~^^^^^^
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 686, in install
    return all([to_install.install() for to_install in packages])
                ~~~~~~~~~~~~~~~~~~^^
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 310, in install
    AutoInstall.install(dependency)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 686, in install
    return all([to_install.install() for to_install in packages])
                ~~~~~~~~~~~~~~~~~~^^
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 361, in install
    subprocess.check_call(
    ~~~~~~~~~~~~~~~~~~~~~^
        [
        ^
    ...<26 lines>...
        stderr=setup_log,
        ^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/lib64/python3.13/subprocess.py", line 419, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', '/tmp/cffi-162222/cffi-1.15.1/setup.py', 'install', '--home=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64', '--root=/', '--prefix=', '--install-lib=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64', '--install-scripts=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/bin', '--install-data=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/data', '--install-headers=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/headers']' returned non-zero exit status 1.

[Michael Catanzaro]

Pull request: https://github.com/WebKit/WebKit/pull/35815

[EWS]

Committed 285831@main (9afb773813fd): <https://commits.webkit.org/285831@main>

Reviewed commits have been landed. Closing PR #35815 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/138842891>