RESOLVED FIXED 28218
[Qt] Missing shadow support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=28218
Summary [Qt] Missing shadow support in Canvas
Ariya Hidayat
Reported 2009-08-12 10:39:19 PDT
Created attachment 34673 [details] Patch v1 Shadow does not work in HTML Canvas. This is for QtWebKit.
Attachments
Patch v1 (15.32 KB, patch)
2009-08-12 10:39 PDT, Ariya Hidayat
no flags
Eric Seidel (no email)
Comment 1 2009-08-12 10:53:18 PDT
Comment on attachment 34673 [details] Patch v1 What does CG have to do with anything? 66 if (m_common->state.shadowsIgnoreTransforms) { 867 // Meaning that this graphics context is associated with a CanvasRenderingContext 868 // We flip the height since CG and HTML5 Canvas have opposite Y axis 869 m_common->state.shadowSize = IntSize(size.width(), -size.height()); 870 } Do you mean GC/GraphicsContext?
Ariya Hidayat
Comment 2 2009-08-12 11:00:08 PDT
CG as in CoreGraphics. Apparently shadow y offset is negative in CanvasRenderingContext2D, likely because it was targeted for CG first. The y-axis inversion can also be found in GraphicsContextSkia, hence why I think the next logical step is to refactor it (and leave out CG as the only one which inverses the axis).
Simon Hausmann
Comment 3 2009-08-13 01:36:57 PDT
Comment on attachment 34673 [details] Patch v1 r=me // Meaning that this graphics context is associated with a CanvasRenderingContext This comment reads a bit strange, but the patch looks great!
Ariya Hidayat
Comment 4 2009-08-13 05:12:15 PDT
Note You need to log in before you can comment on or make changes to this bug.