Bug 28218 – [Qt] Missing shadow support in Canvas

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ariya Hidayat]

Created attachment 34673 [details]
Patch v1

Shadow does not work in HTML Canvas. This is for QtWebKit.

[Eric Seidel (no email)]

Comment on attachment 34673 [details]
Patch v1

What does CG have to do with anything?
66     if (m_common->state.shadowsIgnoreTransforms) {
 867         // Meaning that this graphics context is associated with a CanvasRenderingContext
 868         // We flip the height since CG and HTML5 Canvas have opposite Y axis
 869         m_common->state.shadowSize = IntSize(size.width(), -size.height());
 870     }

Do you mean GC/GraphicsContext?

[Ariya Hidayat]

CG as in CoreGraphics.

Apparently shadow y offset is negative in CanvasRenderingContext2D, likely because it was targeted for CG first. 

The y-axis inversion can also be found in GraphicsContextSkia, hence why I think the next logical step is to refactor it (and leave out CG as the only one which inverses the axis).

[Simon Hausmann]

Comment on attachment 34673 [details]
Patch v1

r=me

// Meaning that this graphics context is associated with a CanvasRenderingContext

This comment reads a bit strange, but the patch looks great!

[Ariya Hidayat]

Comment on attachment 34673 [details]
Patch v1

Landed in http://trac.webkit.org/changeset/47190