Bug 28216 – [CAIRO] getImageData fails on a given rect bigger than the image rect

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Dirk Schulze]

Created attachment 34650 [details]
Cairo fix of getImageData

[CAIRO] getImageData fails on a given rect bigger than the image rect.

I found this bug during my work on SVG feGaussianBlur. Currently only canvas could test it, but we don't allow the it there to make a bigger rect then the image rect.
The problem is, that the destination image and source image were mixed up on creating the imageData. This patch just follows to the behavior of the other ports.

[Eric Seidel (no email)]

Comment on attachment 34650 [details]
Cairo fix of getImageData

Test case?  Or at least an explanation of why one is impossible.

[Dirk Schulze]

Created attachment 34677 [details]
Cairo fix of getImageData

a better Changelog...

[Eric Seidel (no email)]

Comment on attachment 34677 [details]
Cairo fix of getImageData

LGTM.  Not marking cq+ since you're a committer.  You can mark it yourself if you'd like the queue to land this for you.

[Eric Seidel (no email)]

Exception: Unknown committer: [e-mail]

Are you not a committer?  Or do we just not have you in:
WebKitTools/Scripts/modules/committers.py yet?

If not, feel free to add yourself to the committer list.  No review needed.

[Dirk Schulze]

(In reply to comment #4)
> Exception: Unknown committer: [e-mail]
> 
> Are you not a committer?  Or do we just not have you in:
> WebKitTools/Scripts/modules/committers.py yet?
> 
> If not, feel free to add yourself to the committer list.  No review needed.

Added myself to the list.

[Eric Seidel (no email)]

Comment on attachment 34677 [details]
Cairo fix of getImageData

Clearing flags on attachment: 34677

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/cairo/ImageBufferCairo.cpp
Committed r47211
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/cairo/ImageBufferCairo.cpp
r47211 = 43323f18d890228b2275a1ae4d4f9d211d2c001d (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47211

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.