WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282141
Suppress local variable smart pointer warning for ScriptExecutionContext in JS*Callback
https://bugs.webkit.org/show_bug.cgi?id=282141
Summary
Suppress local variable smart pointer warning for ScriptExecutionContext in J...
Ryosuke Niwa
Reported
2024-10-26 16:37:57 PDT
Suppress the warning that ScriptExecutionContext needs to be a RefPtr. Here, we may or may not be in the context thread and we can't use RefPtr since ScriptExecutionContext is never thread safe ref-counted.
Attachments
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2024-10-26 16:46:13 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35760
Ryosuke Niwa
Comment 2
2024-10-26 21:43:55 PDT
<
rdar://problem/138534253
>
EWS
Comment 3
2024-10-26 23:55:47 PDT
Committed
285740@main
(e00595f35d49): <
https://commits.webkit.org/285740@main
> Reviewed commits have been landed. Closing PR #35760 and removing active labels.
Ryosuke Niwa
Comment 4
2024-10-27 09:55:34 PDT
(In reply to Ryosuke Niwa from
comment #2
)
> <
rdar://problem/138534253
>
Not sure what happened here. This radar is clearly nothing to do with this PR.
Ryosuke Niwa
Comment 5
2024-10-27 09:57:49 PDT
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/35774
EWS
Comment 6
2024-10-27 10:25:35 PDT
Committed
285744@main
(c1aec0509161): <
https://commits.webkit.org/285744@main
> Reviewed commits have been landed. Closing PR #35774 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug