Bug 28213 - Some HTMLs are modified by make-script-test-wrappers
Summary: Some HTMLs are modified by make-script-test-wrappers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 28212
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-11 23:34 PDT by Shinichiro Hamaji
Modified: 2009-08-17 23:35 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (3.77 KB, patch)
2009-08-11 23:38 PDT, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff
Patch v2 (5.38 KB, patch)
2009-08-17 21:27 PDT, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2009-08-11 23:34:59 PDT
We should do either re-generate them or add them into exclude list in make-script-test-wrappers.

I believe only fast/js/resources/const.js should be in the excluded list and other HTMLs should be re-generated.
Comment 1 Shinichiro Hamaji 2009-08-11 23:38:32 PDT
Created attachment 34640 [details]
Patch v1


---
 6 files changed, 28 insertions(+), 3 deletions(-)
Comment 2 Shinichiro Hamaji 2009-08-11 23:40:22 PDT
(In reply to comment #1)
> Created an attachment (id=34640) [details]

Note that this patch is intended to be applied after Bug 28212.
Comment 3 Eric Seidel (no email) 2009-08-12 10:19:11 PDT
Comment on attachment 34640 [details]
Patch v1

LGTM.
Comment 4 Eric Seidel (no email) 2009-08-12 14:09:15 PDT
Comment on attachment 34640 [details]
Patch v1

Rejecting patch 34640 from commit-queue.  This patch will require manual commit.

Patch https://bugs.webkit.org/attachment.cgi?id=34640 from bug 28213 failed to download and apply.
Comment 5 Eric Seidel (no email) 2009-08-12 14:23:09 PDT
Applying 34640 from bug 28213.
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/http/tests/wml/access-target-domain-deny.html
patching file LayoutTests/http/tests/wml/access-target-path-deny.html
patching file LayoutTests/http/tests/wml/access-target.html
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 2 with fuzz 3.
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: WebKitTools/Scripts/make-script-test-wrappers
|===================================================================
|--- WebKitTools/Scripts/make-script-test-wrappers
|+++ WebKitTools/Scripts/make-script-test-wrappers
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
1 out of 1 hunk ignored
patch -p0 "WebKitTools/Scripts/make-script-test-wrappers" returned 1.  Pass --force to ignore patch failures.
Logging in as eric@webkit.org...
Rejecting patch 34640 from commit-queue.  This patch will require manual commit.
Comment 6 Eric Seidel (no email) 2009-08-12 15:31:09 PDT
Oh, this patch depends on bug 28212.  It can be re-added to the commit-queue once bug 28212 is landed.
Comment 7 Eric Seidel (no email) 2009-08-17 16:30:35 PDT
Comment on attachment 34640 [details]
Patch v1

Re-adding cq+
Comment 8 Eric Seidel (no email) 2009-08-17 17:31:47 PDT
Comment on attachment 34640 [details]
Patch v1

Rejecting patch 34640 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'dcommit']"  exit_code: 1  cwd: None
Comment 9 Eric Seidel (no email) 2009-08-17 17:32:46 PDT
One of these ChangeLog diffs is malformed.  That is what caused the the commit-queue to fail.
Comment 10 Shinichiro Hamaji 2009-08-17 21:27:44 PDT
Created attachment 35013 [details]
Patch v2


---
 8 files changed, 37 insertions(+), 5 deletions(-)
Comment 11 Shinichiro Hamaji 2009-08-17 21:29:51 PDT
(In reply to comment #9)
> One of these ChangeLog diffs is malformed.  That is what caused the the
> commit-queue to fail.

I've updated my patch. Now it seems that we need to modify Geolocation/* and add canvas-2d-imageData-create-nonfinite.js into the exclude list.
Comment 12 Eric Seidel (no email) 2009-08-17 23:35:17 PDT
Comment on attachment 35013 [details]
Patch v2

Clearing flags on attachment: 35013

Committed r47419: <http://trac.webkit.org/changeset/47419>
Comment 13 Eric Seidel (no email) 2009-08-17 23:35:22 PDT
All reviewed patches have been landed.  Closing bug.