WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282123
[bmalloc] Gigacage::Kind should be an `enum class`
https://bugs.webkit.org/show_bug.cgi?id=282123
Summary
[bmalloc] Gigacage::Kind should be an `enum class`
Marcus Plutowski
Reported
2024-10-25 17:36:20 PDT
rdar://138671348
Right now if you accidentally call bmalloc::heapKind with an int as your kind, C++ will happily coerce it to a Gigacage::Kind and do weird things thereafter. Changing Gigacage::Kind to an `enum class` avoids this problem.
Attachments
Add attachment
proposed patch, testcase, etc.
Marcus Plutowski
Comment 1
2024-10-28 09:37:17 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35795
EWS
Comment 2
2024-10-29 07:37:49 PDT
Committed
285829@main
(cd44912a57e9): <
https://commits.webkit.org/285829@main
> Reviewed commits have been landed. Closing PR #35795 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug