Bug 28211 - Can't click and drag the media controller thumb
Summary: Can't click and drag the media controller thumb
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2009-08-11 21:32 PDT by Simon Fraser (smfr)
Modified: 2009-08-12 18:49 PDT (History)
5 users (show)

See Also:

patch (1.52 KB, patch)
2009-08-12 02:29 PDT, Hin-Chung Lam
simon.fraser: review-
Details | Formatted Diff | Diff
patch + test (4.90 KB, patch)
2009-08-12 16:40 PDT, Hin-Chung Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-08-11 21:32:38 PDT
With TOT, the media slider doesn't move with the cursor when I mouse down and drag it over the controller. The media slider only updates it's position after I mouse up after I drag it.

This is a regression on TOT since this doesn't happen on stock SL 10A342. This regression was caused by http://trac.webkit.org/changeset/46915 since it doesn't happen with previous checkin 46914.

1. Launch a nightly webkit build and go to http://www.mirageband.tv/Night%20and%20Day.mp3
2. Wait for entire file to load then pause it
3. Mouse down directly on the slider and drag the mouse to another section on the controller. Notice the slider doesn't move until you mouse up.
Comment 1 Simon Fraser (smfr) 2009-08-11 21:33:14 PDT
Comment 2 Hin-Chung Lam 2009-08-12 02:29:08 PDT
Created attachment 34647 [details]
Comment 3 Hin-Chung Lam 2009-08-12 02:33:15 PDT
The cause of the regression is that r46915 rejects non mouse actions and mouse actions not from left button. This logic caused trouble because it discards a lot of mouse move events during drag.
Comment 4 Simon Fraser (smfr) 2009-08-12 08:37:37 PDT
Comment on attachment 34647 [details]

Patch looks reasonable but you can make a testcase; in DumpRenderTree, there is an eventSender API that you can use to synthesize mouse events. I think it's important to add a testcase so that this doesn't regress again.
Comment 5 Hin-Chung Lam 2009-08-12 10:29:19 PDT
OK, I'll provide a test case with fix shortly.
Comment 6 Hin-Chung Lam 2009-08-12 16:40:04 PDT
Created attachment 34703 [details]
patch + test
Comment 7 Simon Fraser (smfr) 2009-08-12 17:06:41 PDT
Note that layout tests that use eventSender make assumptions about locations of buttons on the media controller that may not hold across platorms.
Comment 8 Eric Carlson 2009-08-12 17:09:33 PDT
https://bugs.webkit.org/show_bug.cgi?id=28220 will fix the problem Simon mentioned, but for now you may need to land platform specific test results.
Comment 9 Eric Seidel (no email) 2009-08-12 18:00:48 PDT
Comment on attachment 34703 [details]
patch + test

Clearing flags on attachment: 34703

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/media/controls-drag-timebar-expected.txt
	A	LayoutTests/media/controls-drag-timebar.html
	M	WebCore/ChangeLog
	M	WebCore/rendering/MediaControlElements.cpp
Committed r47171
	M	WebCore/ChangeLog
	M	WebCore/rendering/MediaControlElements.cpp
	A	LayoutTests/media/controls-drag-timebar-expected.txt
	A	LayoutTests/media/controls-drag-timebar.html
	M	LayoutTests/ChangeLog
r47171 = 5d54d4d1aa0dd34b843952ff291dcdbf59c39a24 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
Comment 10 Eric Seidel (no email) 2009-08-12 18:00:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Dmitry Titov 2009-08-12 18:49:04 PDT
It turned out that expected.txt is different for windows so landed http://trac.webkit.org/changeset/47174 to split the results.