WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282095
[GTK] Use std::array and ASCIILiteral in DropTargetGtk4.cpp
https://bugs.webkit.org/show_bug.cgi?id=282095
Summary
[GTK] Use std::array and ASCIILiteral in DropTargetGtk4.cpp
Adrian Perez
Reported
2024-10-25 07:44:37 PDT
We could use std::array in the constant arrays in holding MIME type strings in Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp; to try and to remove WTF_ALLOW_UNSAFE_BUFFER_USAGE_{BEGIN,END} usage. While at it, each item in these arrays could be an ASCIILiteral to avoid using GLib functions like g_strv_contains() that don't do bounds checking.
Attachments
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2024-10-25 07:54:01 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35720
EWS
Comment 2
2024-10-25 14:42:44 PDT
Committed
285713@main
(3f563ed0bcbf): <
https://commits.webkit.org/285713@main
> Reviewed commits have been landed. Closing PR #35720 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug