RESOLVED FIXED282067
[JSC] Remove outdated FIXME in JSDOMConvertDate.h 
https://bugs.webkit.org/show_bug.cgi?id=282067
Summary [JSC] Remove outdated FIXME in JSDOMConvertDate.h
Ian Grunert
Reported 2024-10-24 15:34:09 PDT
In JSDOMConvertDate there's a fixme: // FIXME: This should be taking a JSDOMGlobalObject and passing it to jsDate. which is confusing because it's taking a JSC::JSGlobalObject& lexicalGlobalObject, and it's unclear why a JSDOMGlobalObject would be better. The reason for the FIXME appears to be that this function used to accept a JSC::ExecState& state - but in bug 202392 we switched away from that. So it looks like we just forgot to remove the FIXME when we made the relevant change.
Attachments
Add attachment proposed patch, testcase, etc.
Ian Grunert
Comment 1 2024-10-24 15:47:57 PDT
Pull request: https://github.com/WebKit/WebKit/pull/35695
EWS
Comment 2 2024-10-27 11:42:56 PDT
Committed 285746@main (45b4d89d301b): <https://commits.webkit.org/285746@main> Reviewed commits have been landed. Closing PR #35695 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-10-27 11:43:13 PDT
<rdar://problem/138730190>
Note You need to log in before you can comment on or make changes to this bug.