Bug 28205 – [Chromium] drop down menu letter selection, skip selections

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Xiaomei Ji]

steps to reproduce the problem?
1. go to the above website with a dropdown selection menu
2. click the drop down menu to show selections
3. press a letter (such as 'A') to skip to the selection you want
4. it will automatically skip to the 2nd corresponding lettered selection
5. continue press 'A', it selects every other item.

Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=18950

[Xiaomei Ji]

Created attachment 34631 [details]
patch w/ manual test

[Eric Seidel (no email)]

Comment on attachment 34631 [details]
patch w/ manual test

OK.

[Eric Seidel (no email)]

Comment on attachment 34631 [details]
patch w/ manual test

Rejecting patch 34631 from commit-queue.  This patch will require manual commit.

WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1

[Eric Seidel (no email)]

Comment on attachment 34631 [details]
patch w/ manual test

The failure was:
Testing 11049 test cases.
fast/js/global-constructors.html -> failed

Which should be unrelated.  I expect the bots just went red and I didn't notice.

[Xiaomei Ji]

(In reply to comment #4)
> (From update of attachment 34631 [details])
> The failure was:
> Testing 11049 test cases.
> fast/js/global-constructors.html -> failed
> 
> Which should be unrelated.  I expect the bots just went red and I didn't
> notice.

you probably right. There is no such failure in my local run with my change.

[Eric Seidel (no email)]

Comment on attachment 34631 [details]
patch w/ manual test

Clearing flags on attachment: 34631

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	A	WebCore/manual-tests/keyboard_select_elements_with_same_beginning.html
	M	WebCore/platform/chromium/PopupMenuChromium.cpp
Committed r47150
	M	WebCore/ChangeLog
	M	WebCore/platform/chromium/PopupMenuChromium.cpp
	A	WebCore/manual-tests/keyboard_select_elements_with_same_beginning.html
r47150 = bc763ed3dfd04ac8690009160a8baa8af4d3053e (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47150

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.

[Hironori Bono]

*** Bug 28254 has been marked as a duplicate of this bug. ***