RESOLVED FIXED 282039
ODR violation due to redefinition of maxTitleLength contant 
https://bugs.webkit.org/show_bug.cgi?id=282039
Summary ODR violation due to redefinition of maxTitleLength contant
Bartosz Moczulski
Reported 2024-10-24 03:50:25 PDT
Created attachment 473032 [details] Fix proposal With UnifiedSources `--max-bundle-size` set to 16 it is possible for WebLocalFrameLoaderClient.cpp and WebChromeClient.cpp to end up in a single compilation unit. The fact that they both contain a static `maxTitleLength` constant in `WebKit` namespace results in an ODR violation during an attempt to compile them both together. Fix proposal (attached): move maxTitleLength into functions where they are actually needed, like in SessionStateConversion.cpp.
Attachments
Fix proposal (3.81 KB, patch)
2024-10-24 03:50 PDT, Bartosz Moczulski 		no flags
DetailsFormatted DiffDiff
Fix proposal (amended to conform to style requirements) (4.14 KB, patch)
2024-11-06 05:36 PST, Bartosz Moczulski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-10-31 03:51:13 PDT
<rdar://problem/138989376>
Elliott Williams
Comment 2 2024-11-05 11:50:11 PST
Thank you! Looks good, though you'll need to update your patch's commit message to follow WebKit's template. The template should be configured by default in git repositories once you've run `Tools/Scripts/git-webkit setup`. You can also copy it manually from <https://github.com/WebKit/WebKit/blob/main/.github/pull_request_template.md#template>. Contributions via GitHub PR are also welcome, see <https://github.com/WebKit/WebKit/wiki/Contributing#setup> for details.
Bartosz Moczulski
Comment 3 2024-11-06 05:36:58 PST
Created attachment 473152 [details] Fix proposal (amended to conform to style requirements)
Bartosz Moczulski
Comment 4 2024-11-06 05:53:45 PST
Thanks for the tips how to contribute properly, first ones are always hardest. If it's not too much trouble let's stick to .patch flow here. I'll try the PR approach starting with the next improvement, whenever I happen come up with one.
EWS
Comment 5 2024-11-06 11:00:32 PST
Committed 286230@main (44aa509992c1): <https://commits.webkit.org/286230@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 473152 [details].
Note You need to log in before you can comment on or make changes to this bug.