RESOLVED FIXED28202
REGRESSION: run-webkit-tests --quiet hangs 
https://bugs.webkit.org/show_bug.cgi?id=28202
Summary REGRESSION: run-webkit-tests --quiet hangs
Eric Seidel (no email)
Reported 2009-08-11 16:49:13 PDT
run-webkit-tests --quiet hangs My perl-fu is not strong. :(
Attachments
Patch v1 (1.88 KB, patch)
2009-08-11 16:50 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-08-11 16:49:35 PDT
I talked this out with "buu" in #perl, and this was the best we came up with.
Eric Seidel (no email)
Comment 2 2009-08-11 16:50:50 PDT
Created attachment 34614 [details] Patch v1
Eric Seidel (no email)
Comment 3 2009-08-12 09:11:44 PDT
I'm going to check this in w/o review to fix the regression that --quiet now hangs. (Alternatively I could roll out my other patch which caused it to hang.) If anyone has suggestions as to how I should improve this code, I'm happy to change it further. This code is specifically trying to avoid turning the args array back into a string. Perl doesn't seem to have an elegant way to deal with an args array *and* route stderr to /dev/null. Another way I could handle this would be to override the parent's stdout/stderr before running the normal "system" call. But that's also pretty nasty (although slightly less code).
Eric Seidel (no email)
Comment 4 2009-08-12 09:17:28 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests Committed r47109 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r47109 = 86eae88a818613b99c22db8d9631abf4c36eca43 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47109
Note You need to log in before you can comment on or make changes to this bug.