RESOLVED FIXED 282003
REGRESSION(285507@main?): [ macOS iOS Debug ] ASSERTION FAILED: showCount == hideCount in virtual WebCore::MockPaymentCoordinator result of crash in ApplePay 
https://bugs.webkit.org/show_bug.cgi?id=282003
Summary REGRESSION(285507@main?): [ macOS iOS Debug ] ASSERTION FAILED: showCount == ...
Marta Darbinyan
Reported 2024-10-23 13:54:59 PDT
The following tests are appearing false-positive flaky tests in Sequoia EWS. Suspecting it's regressed after 285507@main since the tests started crashing with assertion after this change. In post-commit the tests are flaky crash in iOS and macOS as well. Effected tests in EWS: http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https.html http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrors.https.html http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html http/tests/paymentrequest/ApplePayModifier-multiTokenContexts.https.html http/tests/paymentrequest/payment-response-complete-method.https.html http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html http/tests/paymentrequest/ApplePayModifier-deferredPaymentRequest.https.html http/tests/paymentrequest/payment-response-methodName-attribute.https.html http/tests/paymentrequest/updateWith-displayItems.https.html stderr: ASSERTION FAILED: showCount == hideCount /Volumes/Data/worker/Apple-Sonoma-Debug-Build/build/Source/WebCore/testing/MockPaymentCoordinator.cpp(103) : virtual WebCore::MockPaymentCoordinator::~MockPaymentCoordinator() 1 0x4dcf8126c WebCore::MockPaymentCoordinator::~MockPaymentCoordinator() 2 0x4dcf81565 WebCore::MockPaymentCoordinator::~MockPaymentCoordinator() 3 0x4dcf81589 WebCore::MockPaymentCoordinator::~MockPaymentCoordinator() 4 0x585ea600f std::__1::default_delete<WebCore::PaymentCoordinatorClient>::operator()[abi:sn170006](WebCore::PaymentCoordinatorClient*) const 5 0x585ea5fcc std::__1::unique_ptr<WebCore::PaymentCoordinatorClient, std::__1::default_delete<WebCore::PaymentCoordinatorClient>>::reset[abi:sn170006](WebCore::PaymentCoordinatorClient*) 6 0x585ea5f69 std::__1::unique_ptr<WebCore::PaymentCoordinatorClient, std::__1::default_delete<WebCore::PaymentCoordinatorClient>>::~unique_ptr[abi:sn170006]() 7 0x585ea5f45 std::__1::unique_ptr<WebCore::PaymentCoordinatorClient, std::__1::default_delete<WebCore::PaymentCoordinatorClient>>::~unique_ptr[abi:sn170006]() 8 0x585ea5f25 WTF::UniqueRef<WebCore::PaymentCoordinatorClient>::~UniqueRef() 9 0x585e9a115 WTF::UniqueRef<WebCore::PaymentCoordinatorClient>::~UniqueRef() 10 0x585e9a0ca WebCore::PaymentCoordinator::~PaymentCoordinator() 11 0x585e9a165 WebCore::PaymentCoordinator::~PaymentCoordinator() 12 0x4dcae2ef5 WTF::RefCounted<WebCore::PaymentCoordinator>::deref() const 13 0x4dcae2ea9 WTF::RefCountedAndCanMakeWeakPtr<WebCore::PaymentCoordinator>::deref() const 14 0x4dcf838a1 WebCore::MockPaymentCoordinator::deref() const 15 0x4dcebacce WTF::DefaultRefDerefTraits<WebCore::MockPaymentCoordinator>::derefIfNotNull(WebCore::MockPaymentCoordinator*) 16 0x4dcebac69 WTF::Ref<WebCore::MockPaymentCoordinator, WTF::RawPtrTraits<WebCore::MockPaymentCoordinator>, WTF::DefaultRefDerefTraits<WebCore::MockPaymentCoordinator>>::~Ref() 17 0x4dceb24b5 WTF::Ref<WebCore::MockPaymentCoordinator, WTF::RawPtrTraits<WebCore::MockPaymentCoordinator>, WTF::DefaultRefDerefTraits<WebCore::MockPaymentCoordinator>>::~Ref() 18 0x4dcebac09 WebCore::JSDOMWrapper<WebCore::MockPaymentCoordinator, WTF::RawPtrTraits<WebCore::MockPaymentCoordinator>>::~JSDOMWrapper() 19 0x4dcebabe5 WebCore::JSMockPaymentCoordinator::~JSMockPaymentCoordinator() 20 0x4dceb0025 WebCore::JSMockPaymentCoordinator::~JSMockPaymentCoordinator() 21 0x4dceafc4d WebCore::JSMockPaymentCoordinator::destroy(JSC::JSCell*) 22 0x4e899b137 JSC::JSDestructibleObjectDestroyFunc::operator()(JSC::VM&, JSC::JSCell*) const 23 0x4e899b105 JSC::JSDestructibleObjectHeapCellType::destroy(JSC::VM&, JSC::JSCell*) const 24 0x4e82fc26a JSC::Subspace::destroy(JSC::VM&, JSC::JSCell*) 25 0x4e82f12c1 JSC::PreciseAllocation::sweep() 26 0x4e82d588d JSC::MarkedSpace::sweepPreciseAllocations() 27 0x4e821ca30 JSC::Heap::sweepInFinalize() 28 0x4e821c640 JSC::Heap::finalize() 29 0x4e821be02 JSC::Heap::handleNeedFinalize(unsigned int) 30 0x4e821ad04 JSC::Heap::handleNeedFinalize() 31 0x4e8216f4a JSC::Heap::finishChangingPhase(JSC::GCConductor) com.apple.WebKit.WebContent.Development terminated (pid 81892) for reason: crash LEAK: 2 WebPageProxy History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fpaymentrequest%2FApplePayModifier-deferredPaymentRequest.https.html&test=http%2Ftests%2Fpaymentrequest%2Fpayment-response-complete-method.https.html&test=http%2Ftests%2Fpaymentrequest%2Fpayment-response-payerEmail-attribute.https.html&test=http%2Ftests%2Fssl%2Fapplepay%2FApplePayRequestShippingContact.https.html&test=http%2Ftests%2Fssl%2Fapplepay%2FApplePayRequestShippingContactV3.https.html&test=http%2Ftests%2Fssl%2Fapplepay%2FApplePayShippingAddressChangeEventErrors.https.html&test=http%2Ftests%2Fpaymentrequest%2FApplePayPaymentCompleteDetails-orderDetails.https.html&test=http%2Ftests%2Fpaymentrequest%2Fpayment-response-methodName-attribute.https.html&test=http%2Ftests%2Fpaymentrequest%2FupdateWith-displayItems.https.html&flavor=wk2&style=debug Test Results: https://build.webkit.org/results/Apple-Sequoia-Debug-AppleSilicon-WK2-Tests/285255@main%20(76)/results.html
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-10-23 13:55:32 PDT
<rdar://problem/138506302>
EWS
Comment 2 2024-10-23 14:31:28 PDT
Test gardening commit 285622@main (d4171c21f236): <https://commits.webkit.org/285622@main> Reviewed commits have been landed. Closing PR #35647 and removing active labels.
Chris Dumez
Comment 3 2024-10-23 22:45:49 PDT
Pull request: https://github.com/WebKit/WebKit/pull/35666
EWS
Comment 4 2024-10-24 09:40:59 PDT
Committed 285653@main (3376205b5d9b): <https://commits.webkit.org/285653@main> Reviewed commits have been landed. Closing PR #35666 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.