Bug 28199 - bugzilla-tool : various improvements for running the commit-queue
Summary: bugzilla-tool : various improvements for running the commit-queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-11 16:07 PDT by Eric Seidel (no email)
Modified: 2009-08-12 09:26 PDT (History)
1 user (show)

See Also:


Attachments
Various little fixes for the commit-queue (10.60 KB, patch)
2009-08-11 16:14 PDT, Eric Seidel (no email)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-08-11 16:07:48 PDT
bugzilla-tool : various improvements for running the commit-queue

I've been running the commit-queue today and found a bunch of little bugs in bugzilla-tool which I will post a patch here to fix.
Comment 1 Eric Seidel (no email) 2009-08-11 16:14:41 PDT
Created attachment 34610 [details]
Various little fixes for the commit-queue
Comment 2 Adam Barth 2009-08-11 16:18:38 PDT
I'll review this in detail after dinner.  For the moment, you should use os.devnull instead of "/dev/null"
Comment 3 Adam Barth 2009-08-11 19:16:32 PDT
Comment on attachment 34610 [details]
Various little fixes for the commit-queue

These are all good bugs to fix.  Two minor things to fix before landing:

1) "/dev/null" -> os.devnull

2) "Clearing review flag on attachment" -> this text now doesn't quite match what we're doing.
Comment 4 Eric Seidel (no email) 2009-08-12 09:22:15 PDT
Thanks.  FIxed.
Comment 5 Eric Seidel (no email) 2009-08-12 09:26:26 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bugzilla-tool
	M	WebKitTools/Scripts/modules/bugzilla.py
	M	WebKitTools/Scripts/modules/scm.py
Committed r47111
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/modules/bugzilla.py
	M	WebKitTools/Scripts/modules/scm.py
	M	WebKitTools/Scripts/bugzilla-tool
r47111 = 431ef60608c95da88d3bc13bae5b7663484f029f (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47111