Bug 28198 - Need to move desktopNotificationsDelegate out of IWebUIDelegate.idl
Summary: Need to move desktopNotificationsDelegate out of IWebUIDelegate.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: John Gregg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-11 16:04 PDT by Andrew Wilson
Modified: 2009-08-11 20:30 PDT (History)
2 users (show)

See Also:


Attachments
refactoring of interfaces (9.55 KB, patch)
2009-08-11 17:53 PDT, John Gregg
no flags Details | Formatted Diff | Diff
refactoring of interfaces (9.59 KB, patch)
2009-08-11 17:55 PDT, John Gregg
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-08-11 16:04:56 PDT
Per Maciej:

othermaciej: new methods should be added to a renamed interface that inherits from the original, like IWebUIDelegate2
othermaciej: and the framework should explicitly check whether that interface is implemented before calling them
Comment 1 John Gregg 2009-08-11 17:53:33 PDT
Created attachment 34622 [details]
refactoring of interfaces
Comment 2 John Gregg 2009-08-11 17:55:41 PDT
Created attachment 34624 [details]
refactoring of interfaces

no tabs this time in my ChangeLog
Comment 3 Andrew Wilson 2009-08-11 18:22:55 PDT
I've added aroben and bdash in case they want to review and/or land the fix themselves, otherwise if someone reviews it I can land it tomorrow when someone is around to babysit the Safari build to make sure this fixes it.
Comment 4 Maciej Stachowiak 2009-08-11 20:22:40 PDT
Comment on attachment 34624 [details]
refactoring of interfaces

r=me, thanks for fixing, and sorry for overlooking this.
Comment 5 Mark Rowe (bdash) 2009-08-11 20:30:47 PDT
Landed with some style fix-ups in r47084.