Bug 28189 - run-webkit-tests --quiet should not output build-dumprendertree output
Summary: run-webkit-tests --quiet should not output build-dumprendertree output
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-11 14:31 PDT by Eric Seidel (no email)
Modified: 2009-08-11 15:05 PDT (History)
0 users

See Also:


Attachments
Make run-webkit-tests --quiet actually quiet (1.64 KB, patch)
2009-08-11 14:33 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Updated patch (1.55 KB, patch)
2009-08-11 14:38 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Update comments (1.55 KB, patch)
2009-08-11 15:02 PDT, Eric Seidel (no email)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-08-11 14:31:09 PDT
run-webkit-tests --quiet should not output build-dumprendertree output

This required a surprising amount of perl ninjary.  I will be so glad when that wicked old language is dead. :(
Comment 1 Eric Seidel (no email) 2009-08-11 14:33:05 PDT
Created attachment 34594 [details]
Make run-webkit-tests --quiet actually quiet


---
 2 files changed, 22 insertions(+), 3 deletions(-)
Comment 2 Eric Seidel (no email) 2009-08-11 14:38:55 PDT
Created attachment 34596 [details]
Updated patch


---
 2 files changed, 21 insertions(+), 2 deletions(-)
Comment 3 Eric Seidel (no email) 2009-08-11 15:02:01 PDT
Created attachment 34601 [details]
Update comments


---
 2 files changed, 21 insertions(+), 2 deletions(-)
Comment 4 Adam Barth 2009-08-11 15:02:51 PDT
Comment on attachment 34601 [details]
Update comments

Seems reasonable, assuming the Perl magic does what it looks like it should do.
Comment 5 Eric Seidel (no email) 2009-08-11 15:05:37 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/run-webkit-tests
Committed r47066
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/run-webkit-tests
r47066 = 47f317d3a54a8c0eba39936bac967272116a6580 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47066