WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
281831
Add check to makeUniqueRef<T>() to make sure T is not ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281831
Summary
Add check to makeUniqueRef<T>() to make sure T is not ref-counted
Chris Dumez
Reported
2024-10-19 18:38:38 PDT
Add check to makeUniqueRef<T>() to make sure T is not ref-counted, similarly to what we already to for makeUnique<T>(). Introduce a makeUniqueRefWithoutRefCountedCheck<T>() to bypass the check (in case of ref-counting forwarding). Also fix the bugs that were found by the new check.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2024-10-19 19:11:49 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35497
EWS
Comment 2
2024-10-21 08:19:38 PDT
Committed
285507@main
(bb010d9a1457): <
https://commits.webkit.org/285507@main
> Reviewed commits have been landed. Closing PR #35497 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-10-21 08:20:17 PDT
<
rdar://problem/138319519
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug