RESOLVED FIXED281751
[WPE] Rename WPEMonitor to WPEScreen 
https://bugs.webkit.org/show_bug.cgi?id=281751
Summary [WPE] Rename WPEMonitor to WPEScreen
Jani Hautakangas
Reported 2024-10-18 07:55:45 PDT
The current naming of "WPEMonitor" in the WPE Platform doesn’t fit well across all device form factors. "WPEMonitor" suggests an individual display screen, but this naming feels out of place for smaller devices such as mobile phones. This naming convention is inherited from Gtk/Gdk, where GdkMonitor was introduced in GTK4 to replace the older GdkScreen. However, GdkMonitor was a compromise due to accumulated technical debt in GdkScreen. Additionally, in WebKit, there are many "*Monitor" classes used to monitor events, progress, and other functionalities. "WPEMonitor" could easily be confused with these, leading to potential misunderstandings about its purpose. Therefore, renaming WPEMonitor to WPEScreen would provide a clearer and more appropriate representation of its function.
Attachments
Add attachment proposed patch, testcase, etc.
Jani Hautakangas
Comment 1 2024-10-18 08:37:28 PDT
Pull request: https://github.com/WebKit/WebKit/pull/35433
EWS
Comment 2 2024-10-22 21:40:45 PDT
Committed 285586@main (ac17704df9a5): <https://commits.webkit.org/285586@main> Reviewed commits have been landed. Closing PR #35433 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.